-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update node docs #7368
Merged
Merged
Update node docs #7368
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
e1d9645
wip
silesky 8864a6a
update docs
silesky 212aadc
wip
silesky 498b292
wip
silesky f8682ca
wip
silesky 047438b
Update src/connections/sources/catalog/libraries/server/node/index.md
silesky fcde6fb
Update src/connections/sources/catalog/libraries/server/node/index.md
silesky c85abfd
Update src/connections/sources/catalog/libraries/server/node/index.md
silesky 987f8df
Update src/connections/sources/catalog/libraries/server/node/index.md
silesky adab75d
Update src/connections/sources/catalog/libraries/server/node/index.md
silesky 8f2c5bd
Update src/connections/sources/catalog/libraries/server/node/index.md
stayseesong File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@silesky is there a reason why you deleted this before the table?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I didn't delete the table? I updated the table to be accurate/relevant to nodejs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't say you deleted the table. I'm asking why you deleted line 406
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I misread! I thought the critical vs non critical category was more confusing that useful, and just added that information to the plug-in description of each plug-in type (i.e. Load errors can block the pipeline). This makes this table more like the analytics.js one