-
Notifications
You must be signed in to change notification settings - Fork 371
[Amazon Conversions API] Updating documentation based on questions asked in client calls #7717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bansrav
wants to merge
6
commits into
segmentio:develop
Choose a base branch
from
bansrav:develop
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+13
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@stayseesong , can you pleas review this PR? |
stayseesong
requested changes
Jun 27, 2025
src/connections/destinations/catalog/actions-amazon-conversions-api/index.md
Outdated
Show resolved
Hide resolved
src/connections/destinations/catalog/actions-amazon-conversions-api/index.md
Outdated
Show resolved
Hide resolved
src/connections/destinations/catalog/actions-amazon-conversions-api/index.md
Show resolved
Hide resolved
src/connections/destinations/catalog/actions-amazon-conversions-api/index.md
Outdated
Show resolved
Hide resolved
stayseesong
reviewed
Jun 27, 2025
src/connections/destinations/catalog/actions-amazon-conversions-api/index.md
Outdated
Show resolved
Hide resolved
All the feedback have been incorporated. @stayseesong , can you please take a look again? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
content-update
updates to content that are not new features, includes grammar fixes, added notes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Updating documentation based on questions asked in client calls
Merge timing
ASAP once approved
Related issues (optional)