Task/slider #2
Open
Task/slider #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucasBadico
reviewed
Mar 10, 2018
slider.html
Outdated
| </div> | ||
| </section> | ||
|
|
||
| <script> |
There was a problem hiding this comment.
vc manja pq colocamos esse tipo de script no fim da pagina?
There was a problem hiding this comment.
pra ler depois que a pagina abrir??
There was a problem hiding this comment.
chamam de javascript nao intrusivo. desse jeito vc sabe que a sua pagina vai carregar ele por ultimo.
slider.html
Outdated
| showDivs(slideIndex += n); | ||
| } | ||
|
|
||
| function showDivs(n) { |
There was a problem hiding this comment.
vc que criou essas funcoes?
There was a problem hiding this comment.
kkk entao vamos apagar. e vc vai fazer do zero. E to falando serio 😈
css/style.css
Outdated
| -webkit-animation: fadein 1s; /* Safari and Chrome */ | ||
| -o-animation: fadein 1s; /* Opera */ | ||
| } | ||
| @keyframes fadein { |
There was a problem hiding this comment.
jkdfskfjjh ah fsa hsfadjhsdfajfdshajkfesahjkfad
felipeverissimo
requested changes
Mar 10, 2018
slider.html
Outdated
| var slideIndex = 1; | ||
| showDivs(slideIndex); | ||
|
|
||
| function plusDivs(n) { |
There was a problem hiding this comment.
por skldfjflçds jlkqwjlkfjsdahj fkodsç
slider.html
Outdated
| showDivs(slideIndex += n); | ||
| } | ||
|
|
||
| function showDivs(n) { |
slider.html
Outdated
| var x = document.getElementsByClassName("item"); | ||
| for (i = 0; i < x.length; i++) { | ||
| x[i].style.display = "none"; | ||
| } |
There was a problem hiding this comment.
fsajç hshaf fwqeahfsad
|
Teste ....
Em 10 de mar de 2018 9:52 AM, "Felipe Verissimo" <[email protected]>
escreveu:
… ***@***.**** requested changes on this pull request.
------------------------------
In slider.html
<#2 (comment)>:
> + <h1>AQUI INICIAMOS GRANDES COISAS</h1>
+ </div>
+ </div>
+ <div class="item" style="background: url('img/imagem2.jpg');"></div>
+ <div class="item" style="background: url('img/imagem3.jpg');"></div>
+ <button class="button display-left" onclick="plusDivs(-1)">❮</button>
+ <button class="button display-right" onclick="plusDivs(+1)">❯</button>
+ </div>
+ </div>
+ </section>
+
+ <script>
+ var slideIndex = 1;
+ showDivs(slideIndex);
+
+ function plusDivs(n) {
por skldfjflçds jlkqwjlkfjsdahj fkodsç
------------------------------
In slider.html
<#2 (comment)>:
> + <div class="item" style="background: url('img/imagem3.jpg');"></div>
+ <button class="button display-left" onclick="plusDivs(-1)">❮</button>
+ <button class="button display-right" onclick="plusDivs(+1)">❯</button>
+ </div>
+ </div>
+ </section>
+
+ <script>
+ var slideIndex = 1;
+ showDivs(slideIndex);
+
+ function plusDivs(n) {
+ showDivs(slideIndex += n);
+ }
+
+ function showDivs(n) {
concodo
------------------------------
In slider.html
<#2 (comment)>:
> + if (n < 1) {slideIndex = x.length}
+ for (i = 0; i < x.length; i++) {
+ x[i].style.display = "none";
+ }
+ x[slideIndex-1].style.display = "block";
+ }
+
+ var slideIndex = 0;
+ carousel();
+
+ function carousel() {
+ var i;
+ var x = document.getElementsByClassName("item");
+ for (i = 0; i < x.length; i++) {
+ x[i].style.display = "none";
+ }
fsajç hshaf fwqeahfsad
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#2 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AfkyOWllYQrAFopTwiKEs6yQ_KxlwIm0ks5tc8ylgaJpZM4ShwOL>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Criado o laytout do sliders, junto css, e JS