Fix date issues when user inputs: date out of bound or date_to earlier than date_from

[toropok]

Description of the issue/feature this PR addresses

fix for #32 issue

[toropok]

I dont remember should I add that to changes.rst in the core project :)

[ramonski]

I dont remember should I add that to changes.rst in the core project :)

Hi Leonid,
Thanks for the fixture!

Please always update the Changelog in the Add-on where the changes happened:
https://github.com/senaite/senaite.databox/blob/master/docs/Changelog.rst

Thanks

[ramonski]

Does it have a reason why you added the import at class level?

[toropok]

I recall the reason was that dtime was unreachable from a template expression statement, if import statement declared for module level..

Would you think its better to return import statement to the module level and provide sort of wrapper from DataBoxView class to that template expression? Or even somehow import dtime right in template (is that possible?)?

[ramonski]

Ok, that's strange... Maybe this is because of restricted Python, but not sure.
Anyhow, I think that accessing the module directly is bad style and should be avoided.
Better create two more property methods in the class, that return the right value for you, e.g.:

@property
def date_from(self):
    if not self.context.date_from:
        return ""
    return dtime.date_to_string(self.context.date_from)

And use then this in your template:

<input type="date"
       class="form-control"
       tal:attributes="value python:view.date_from"
       name="senaite.databox.date_from"/>

[toropok]

Thanks! I've added properties.

Also, I've added date_to > date_from comparison, which should make report behaviour more intuitive. In case user puts date_to earlier than date_from - we use [date_from, date_from] range for date query.

[ramonski]

Hi @toropok,
apologies for late merging! I no longer had the PR on my radar ...