Feat: Add missing sidecar and global parameter for deployments & hooks #1230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dromadaire54
force-pushed
the
add-sidecar-volume
branch
from
06ca56a
to
0696ed6
Compare
dromadaire54
force-pushed
the
add-sidecar-volume
branch
from
0696ed6
to
f655320
Compare
dromadaire54
force-pushed
the
add-sidecar-volume
branch
from
96b935d
to
72df97d
Compare
dromadaire54
force-pushed
the
add-sidecar-volume
branch
3 times, most recently
from
be2d20a
to
8285160
Compare
dromadaire54
force-pushed
the
add-sidecar-volume
branch
from
8285160
to
3122525
Compare
|
@Mokto I don't understand why the chart testing not working. There are errors about clickhouse. |
|
Can you please rebase your branch? A fix has been merged into develop. |
|
Sorry @Mokto I rebased my branch but it didn't fix it. |
|
That's fine, it's a different failure that @TartanLeGrand is working on. |
|
Yes, when have been upgrade correctly the chart to sentry 24.6.0 just rebase your PR 😉 |
|
Thanks @TartanLeGrand and @Mokto for the answer. |
|
👋 Hi, @dromadaire54, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request consists to add global sidecars or volumes to all deployments including hooks. In my case, the same sidecar and volume were added in all deployments and duplicated in the values file. Furthermore, I added the missing sidecar component in the deployments and hooks level. Let me know if you are suggestions about my PR.