New Generate Modes #250
New Generate Modes #250
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #250 +/- ##
==========================================
+ Coverage 99.46% 99.46% +0.01%
==========================================
Files 4 4
Lines 730 738 +8
Branches 109 111 +2
==========================================
+ Hits 726 734 +8
Misses 2 2
Partials 2 2 ☔ View full report in Codecov by Sentry. |
| elif self.generate_mode == GenerateMode.F1F2_VS_F1.value: | ||
| data1_ = self.function1(point[0], point[1]).real * self.function2(point[0], point[1]).real | ||
| data2_ = self.function1(point[0], point[1]).real | ||
| elif self.generate_mode == GenerateMode.F1F2_VS_F2.value: | ||
| data1_ = self.function1(point[0], point[1]).real * self.function2(point[0], point[1]).real | ||
| data2_ = self.function2(point[0], point[1]).real |
There was a problem hiding this comment.
Not sure if these are food atomic modes. If we add this we should add F1_VS_F1F2, F1_VS_F2F1, and F1+F2_VS_F1 etc. Therefore I think that's not a good idea to add this mode.
There was a problem hiding this comment.
If it doesn't produce a beautiful mode, it is also not harmful.
There was a problem hiding this comment.
I don't know. I wanted this set to be atomic, or at least closed under the operations we're defining (including all cases).
There was a problem hiding this comment.
I understand your point, and if you're okay with it, I will add F1_VS_F1F2 and F1_VS_F2F1 in the next version of Samila. I generated this image using the F1F2_VS_F1 mode:
There was a problem hiding this comment.
OK, that's beautiful. I guess that's fine then.
Reference Issues/PRs
What does this implement/fix? Explain your changes.
F1F2_VS_F1F1F2_VS_F2Any other comments?