Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating versionSwitcher #286

Merged
merged 3 commits into from
Nov 25, 2024
Merged

Conversation

mavi-sqr
Copy link
Contributor

@mavi-sqr mavi-sqr commented Nov 7, 2024

- version switcher:
I was able to reproduce the issue very randomly locally. From time to time, I have been able to reproduce this.

Grabacion.de.pantalla.2024-11-06.a.las.18.13.50.mov

I didn't find any logic breaking anything or any event—preventDefault causing the issue.
My guess was a possible conflict caused by the 2 properties to and onClick.Sometimes, different browsers may handle these interactions differently, leading to inconsistencies.

Copy link

netlify bot commented Nov 7, 2024

Deploy Preview for seqera-docs ready!

Name Link
🔨 Latest commit b4e5707
🔍 Latest deploy log https://app.netlify.com/sites/seqera-docs/deploys/67377798b31ac6000830c9a6
😎 Deploy Preview https://deploy-preview-286--seqera-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@justinegeffen justinegeffen requested a review from ewels November 12, 2024 17:31
Copy link
Member

@ewels ewels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ewels ewels merged commit 64bf313 into master Nov 25, 2024
6 checks passed
@ewels ewels deleted the DP-679-version-switcher-not-working-linux branch November 25, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants