Add namespace to secret creation heredoc #492
Conversation
✅ Deploy Preview for seqera-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
IMO adding an explicit namespace is always a good idea. If you don't do that, it will either end up in the IIRC I had this discussion with docs awhile ago on another ticket and there was a deliberate decision to not include it (I dont recall the reason). I'll see if I can dig up the link. Edit: Here's the link: #133 |
When I followed the instructions, I did exactly this and it took me a hot minute to work it out. |
|
Taking @gwright99's comments into account it would probably make sense to update this doc to better reflect the changes we made to the enterprise content last year. @adamrtalbot, would that work? The change is here: https://github.com/seqeralabs/docs/pull/133/files. |
| @@ -44,6 +44,7 @@ This guide applies a Kubernetes manifest that creates a service account named `t | |||
| kind: Secret | |||
| metadata: | |||
| name: tower-launcher-token | |||
| namespace: tower-nf | |||
There was a problem hiding this comment.
The next paragraph down also could do with adding the namespace explicitly to the kuebctl command to verify that token was created successfully.
kubectl -n tower-nf describe secrets/tower-launcher-tokenThere was a problem hiding this comment.
Also slightly further down - also mossing a ns
kubectl describe secret <SERVICE-ACCOUNT-TOKEN-NAME> | grep -E '^token' | cut -f2 -d':' | tr -d '\t 'Signed-off-by: Justine Geffen <[email protected]>
| 1. Confirm that Kubernetes created the persistent API token secret: | ||
|
|
||
| ```bash | ||
| kubectl describe secrets/tower-launcher-token |
There was a problem hiding this comment.
| kubectl describe secrets/tower-launcher-token | |
| kubectl -n tower-nf describe secrets/tower-launcher-token |
| - To authenticate using a Kubernetes service account, enter your **Service account token**. Obtain the token with the following command: | ||
|
|
||
| ```bash | ||
| kubectl describe secret <SERVICE-ACCOUNT-TOKEN-NAME> | grep -E '^token' | cut -f2 -d':' | tr -d '\t ' |
There was a problem hiding this comment.
| kubectl describe secret <SERVICE-ACCOUNT-TOKEN-NAME> | grep -E '^token' | cut -f2 -d':' | tr -d '\t ' | |
| kubectl -n tower-nf describe secret <SERVICE-ACCOUNT-TOKEN-NAME> | grep -E '^token' | cut -f2 -d':' | tr -d '\t ' |
|
Thanks for this, @adamrtalbot! I've implemented the suggested changes. Please could you give them a review and then I think we're good to merge. :) |
Signed-off-by: Justine Geffen <[email protected]>
Signed-off-by: Justine Geffen <[email protected]>
The heredoc for creating a k8s token was missing a namespace, or at least it didn't match the rest of the docs that focus on the tower-nf namespace. This PR adds it so that it matches up.