Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial Vale configuration #6

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Add initial Vale configuration #6

merged 1 commit into from
Apr 11, 2024

Conversation

jason-seqera
Copy link
Contributor

@jason-seqera jason-seqera commented Apr 2, 2024

Partial configuration.

Adds GitHub Action.

@jason-seqera jason-seqera self-assigned this Apr 2, 2024
Copy link

netlify bot commented Apr 2, 2024

Deploy Preview for seqera-docs ready!

Name Link
🔨 Latest commit 7b05c61
🔍 Latest deploy log https://app.netlify.com/sites/seqera-docs/deploys/66185ec990d3a7000817925e
😎 Deploy Preview https://deploy-preview-6--seqera-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@edmundmiller
Copy link

I'd add .github/styles to the .gitignore as those are packages and people writing the docs shouldn't be editing them directly.

https://github.com/nf-core/website/blob/4aafc40d009c9897cf6412cb9a4df4522abdd015/.gitignore#L30-L41

@jason-seqera
Copy link
Contributor Author

@edmundmiller, excellent idea; I wasn't thinking along those lines.

@jason-seqera jason-seqera marked this pull request as ready for review April 8, 2024 13:09
@jason-seqera jason-seqera force-pushed the add-vale-config branch 2 times, most recently from d9a01ff to bd71586 Compare April 8, 2024 13:13
@jason-seqera
Copy link
Contributor Author

I've updated this so that the GitHub Action does not run automatically, because right now it just kills the action because of the volume of warnings.

@jason-seqera jason-seqera merged commit 1d4900a into master Apr 11, 2024
3 of 4 checks passed
@jason-seqera jason-seqera deleted the add-vale-config branch April 11, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants