Update for changes in v7 #284
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having a lock file will cause the CI to install outdated versions of sequelize when running tests.
The arguments for configuring Sequelize has changed in v7. Use separate compatible base configs for each version.
Update locations for the sqlcmd tools which seems to have changed in the latest image.
The dialects are now provided by separate packages. Add the new packages to the CI and documentation.
Versions of sinon >= 11 is incompatible with Node.js v10, which breaks the ci tests. Also pin nise as it's not following Node.js version.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SSCCE was still running on alpha 36 of Sequelize v7 due to the yarn lock file being committed to the repository. When I removed it to make it run on alpha 43 there was a lot of things broken due to changes in v7.