Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for voice status #2982

Merged
merged 3 commits into from
Oct 16, 2024
Merged

Conversation

rhgndf
Copy link
Contributor

@rhgndf rhgndf commented Oct 3, 2024

Haven't seen any docs to change voice status in this crate.

API here: discord/discord-api-docs#6400

This patch makes changing voice status possible. Not familiar with the code base, so I'm not sure if this is the best way to do it.

@github-actions github-actions bot added builder Related to the `builder` module. http Related to the `http` module. labels Oct 3, 2024
@arqunis arqunis added enhancement An improvement to Serenity. discord feature Related to Discord's functionality. labels Oct 3, 2024
Copy link
Member

@arqunis arqunis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but could you change the use of the json! macro to an intermediary struct? We like to avoid temporary heap allocations as much as possible.

src/builder/edit_channel.rs Outdated Show resolved Hide resolved
@arqunis arqunis merged commit 7cb10ad into serenity-rs:current Oct 16, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
builder Related to the `builder` module. discord feature Related to Discord's functionality. enhancement An improvement to Serenity. http Related to the `http` module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants