Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support OpenSSL 1.1.1 #461

Closed
wants to merge 1 commit into from
Closed

Support OpenSSL 1.1.1 #461

wants to merge 1 commit into from

Conversation

L-as
Copy link

@L-as L-as commented Jan 7, 2019

This PR updates to version 0.10 of the OpenSSL crate to support version 1.1.1 of OpenSSL.
To do this, I had to update some other crates across breaking changes, however serenity still compiles and all tests pass, but I can not assert that everything works alright.
In addition, I do not know if any of the changed crates are public dependencies, because if so, this is a breaking change too.

Update to version 0.10 of the OpenSSL crate to support
version 1.1.1 of OpenSSL.
@Erk-
Copy link
Member

Erk- commented Jan 7, 2019

We have used our own branch because of a bug happening with the websocket crate. For more information about that read the #394 issue. This is already fixed on the next major version where it will also be possible to use rustls for tls.

@L-as
Copy link
Author

L-as commented Jan 7, 2019

Sounds great! Where can I find the next major version?

@arqunis
Copy link
Member

arqunis commented Jan 7, 2019

The next major version is v.0.6.x, albeit the rustls support hasn't been merged yet, but it will.

@Erk-
Copy link
Member

Erk- commented Jan 7, 2019

If you use v.0.6.x I would recommend setting a commit you use as there is still major changes there are waiting to be merged. For example:

[dependencies.serenity]
git = "https://github.com/serenity-rs/serenity"
rev = "3c166e3"

@L-as
Copy link
Author

L-as commented Jan 7, 2019

Thanks! I will close this PR now since it's obviously unneeded.

@L-as L-as closed this Jan 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants