Skip to content
This repository has been archived by the owner on Feb 27, 2022. It is now read-only.

support .net 4.0 #10

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

support .net 4.0 #10

wants to merge 3 commits into from

Conversation

seayxu
Copy link

@seayxu seayxu commented Jul 16, 2021

support .net 4.0

@Numpsy
Copy link

Numpsy commented Jul 16, 2021

I think the CI failure is because the build scripts also need updating to use a newer dotnet sdk version, e.g.

  • change appveyor.yml to use the Visual Studio 2019 image instead of Visual Studio 2015 and remove the step that installs the dotnet core 1.0 SDK
  • either remove global.json or update it to use newer SDK version

?

@seayxu
Copy link
Author

seayxu commented Jul 16, 2021

@Numpsy I fixed.

@nblumhardt
Copy link
Contributor

Thanks for your PR. Unfortunately, it's not practical for us to add further support for obsolete framework versions - though it should be straightforward to maintain a private (or public) fork of the package that adds it. Happy to help if you need a hand to get it running.

@Numpsy
Copy link

Numpsy commented Jul 17, 2021

I think the PR changes to use up to date build tools and to add a netstandard2.0 target are a useful change themselves, .net 4.0 aside?

@nblumhardt
Copy link
Contributor

@Numpsy definitely! If anyone is keen to bundle up the modernization that would be most welcome 👍

@seayxu
Copy link
Author

seayxu commented Jul 19, 2021

ok,just move .net 4.0 framework if you think it not need.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants