-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deployment #1449
Merged
Merged
Deployment #1449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* DB-Layer only responds with valid uuids currently * In the future this is not needed once the sql query is inside api due to proper filter in the query
DB-Layer should not respond with an invalid alias (in the long run we will have control over it anyways)
This test is not needed after we migrate the DB layer into the API
Concerning https://serlo.github.io/unused-graphql-properties/ those endpoints are never used
Actually this is a better name IMHO :-)
refactor: Rename "schema/notification" to "schema/events"
refactor: Split code for events and notifications
refactor(event): Move events query into API
refactor(event)!: Remove AbstractUuid.events and User.eventsByUser
test: Make MSW to bypass to DB-Layer
chore: Enable source-maps in "yarn start"
refactor(database): Add fetchOptional() + better transaction handling
fix(database): Use proper rollback()
test(database): Close DB after tests
fixtures: Remove empty source file
chore: Upgrade dependencies
Co-authored-by: AndreasHuber <[email protected]>
User management for local development
…tabase-layer Migrate set thread status from database layer
…s for an array of IDs instead of only a single ID in order to have a test for what was the first error during implementation
refactor(subject): use database directly for subjects query
test(set-thread-status): remove dependency of test on certain ID
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UuidResolver
#1441Dependencies