Fix mysql deadlock #1787
Merged
Fix mysql deadlock #1787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 29, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kulla
The merging of dependabots is getting stuck because of the deadlock. It is caused by the fact that we trying to do two inserts at the same time in the
addRolefunctions, while the mysql is locking the tables.Although there was discussion for adding roles that don't exist yet, it seems unnecessary now. So removing the insert of an automatic creation of role will solve it.
As a followup we can throw an error, report and adapt the tests (what can be pretty annoying since the dummy database doesn't have at the moment the used roles in code).