refactor(asset-proxy): increase cache of cf edge and set it for browser

serlo · Oct 31, 2024 · c2030ce · c2030ce
1 parent 69abfbe
commit c2030ce
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/__tests__/asset-proxy.ts b/__tests__/asset-proxy.ts
@@ -33,6 +33,9 @@ test('request to https://asset-proxy.serlo.org/image?url=* gets asset from url q
   expect(response.status).toBe(200)
   expect(response.headers.get('content-type')).toBe('image/png')
   expect(response.headers.get('Set-Cookie')).toBeNull()
+  expect(response.headers.get('cache-control')).toBe(
+    'public, max-age=31536000, immutable',
+  )
 })
 
 describe('returns placeholder', () => {

diff --git a/src/asset-proxy.ts b/src/asset-proxy.ts
@@ -19,12 +19,13 @@ export async function assetProxy(request: Request): Promise<Response | null> {
   }
 
   const originalResponse = await fetch(assetUrl, {
-    cf: { cacheTtl: 24 * 60 * 60 },
+    cf: { cacheTtl: 24 * 60 * 60 * 30 },
   })
 
   if (originalResponse.ok && isImageResponse(originalResponse)) {
     const response = new Response(originalResponse.body, originalResponse)
     response.headers.delete('set-cookie')
+    response.headers.set('cache-control', 'public, max-age=31536000, immutable')
     return response
   }