Merge pull request #4452 from serlo/fix/restrict-editor-package-impor…

…ts-within-editor

fix(editor): restrict @editor/package imports to avoid dep cycle

packages/editor/src/___dev-demo/preview.tsx

@@ -1,4 +1,5 @@
 import { showToastNotice } from '@editor/editor-ui/show-toast-notice'
+// eslint-disable-next-line no-restricted-imports
 import { EditorPluginType, SerloEditor, SerloRenderer } from '@editor/package'
 import { LearnerEventData } from '@editor/plugin/helpers/editor-learner-event'
 import type { AnyEditorDocument } from '@editor/types/editor-plugins'

packages/editor/src/___dev-demo/standalone.tsx

@@ -1,3 +1,4 @@
+// eslint-disable-next-line no-restricted-imports
 import { SerloEditor } from '@editor/package'
 import { StrictMode } from 'react'
 import { createRoot } from 'react-dom/client'

packages/editor/src/editor-integration/create-plugins.tsx

@@ -1,4 +1,3 @@
-import type { SupportedLanguage } from '@editor/package'
 import type { EditorPlugin, StringStateType } from '@editor/plugin'
 import { anchorPlugin } from '@editor/plugins/anchor'
 import { articlePlugin } from '@editor/plugins/article'
@@ -41,6 +40,7 @@ import { textAreaExercisePlugin } from '@editor/plugins/text-area-exercise'
 import { unsupportedPlugin } from '@editor/plugins/unsupported'
 import { videoPlugin } from '@editor/plugins/video'
 import { EditorPluginType } from '@editor/types/editor-plugin-type'
+import type { SupportedLanguage } from '@editor/types/language-data'
 import { TemplatePluginType } from '@editor/types/template-plugin-type'
 
 import { createTestingImagePlugin } from './image-with-testing-config'

packages/eslint-config/editor.js

@@ -53,6 +53,7 @@ module.exports = {
   rules: {
     // eslint
     'no-duplicate-imports': 'error',
+    'no-restricted-imports': ['error', '@editor/package'],
     'no-console': 'warn',
     'no-warning-comments': 'warn',
     eqeqeq: ['error', 'always'],