Skip to content

Commit

Permalink
Merge pull request #4184 from serlo/fix/ci-and-publish-new-editor-ver…
Browse files Browse the repository at this point in the history
…sion

Fix/ci and publish new editor version
  • Loading branch information
CodingDive authored Oct 11, 2024
2 parents 6924d9e + c9ba758 commit 6ad303b
Show file tree
Hide file tree
Showing 5 changed files with 12 additions and 10 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/editor.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,8 @@ jobs:
echo "already_published=true" >> $GITHUB_OUTPUT
else
echo "already_published=false" >> $GITHUB_OUTPUT
fi
- name: Publish to npm
if: steps.check_published.outputs.already_published == 'false'
run: yarn editor:publish
Expand Down
12 changes: 6 additions & 6 deletions packages/editor/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
## Changelog for version 0.15.4
## Changelog for version 0.16.0

- ci(fix): Only publish new version after PR gets merged
- Ci/GitHub action creates pr with changeset
- refactor: move experiments to editor
- fix(plugin-rows): hydration error in anchor link copy tool
- fix(exercise): update titles
- feat(editor): Enable gallery plugin, free text excercise plugin and interactive image (dropzone) plugin
- fix(rows): check if interactive exercise plugins are supported in menu items filter
- Some changes to make editor code work in serlo-editor-as-lti-tool
- fix(editor-packages): Use one redux store per instance of editor
- fix(e2e): adapt math tests
2 changes: 1 addition & 1 deletion packages/editor/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@serlo/editor",
"version": "0.15.4",
"version": "0.16.0",
"homepage": "https://de.serlo.org/editor",
"bugs": {
"url": "https://github.com/serlo/frontend/issues"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ export function PluginCopyTool({ pluginId, noSeparator }: PluginCopyToolProps) {
void navigator.clipboard.writeText(JSON.stringify(rowsDocument))
showToastNotice(rowsStrings.copySuccess, 'success', 2000)
showToastNotice('👉 ' + rowsStrings.pluginCopyInfo, undefined, 4000)
}, [pluginId, rowsStrings])
}, [pluginId, rowsStrings, store])

if (!navigator.clipboard) return null

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ export function PluginDefaultTools({ pluginId }: PluginDefaultToolsProps) {
() =>
selectParentPluginType(store.getState(), pluginId) ===
EditorPluginType.Rows,
[pluginId]
[pluginId, store]
)

const handleDuplicatePlugin = useCallback(() => {
Expand All @@ -47,7 +47,7 @@ export function PluginDefaultTools({ pluginId }: PluginDefaultToolsProps) {
document,
})
)
}, [dispatch, pluginId])
}, [dispatch, pluginId, store])

const handleRemovePlugin = useCallback(() => {
const parent = selectChildTreeOfParent(store.getState(), pluginId)
Expand Down

0 comments on commit 6ad303b

Please sign in to comment.