Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(e2e): add e2e-test as standalone package #3193

Merged
merged 12 commits into from
Dec 12, 2023
Merged

refactor(e2e): add e2e-test as standalone package #3193

merged 12 commits into from
Dec 12, 2023

Conversation

elbotho
Copy link
Member

@elbotho elbotho commented Dec 12, 2023 •
edited
Loading

(replacement of #3177)

  • this adds e2e tests as a standalone package instead of a workspace (like you suggested @Entkenntnis)
  • somehow that means we don't have to install playwright in the CI (still don't know why but it's nice)
  • it uses the latest test code now (sorry @hejtful …)
  • seems to work even with workers again, but let's see how reliably (@hejtful your improvements are still welcome here)

@vercel Vercel
Copy link

vercel bot commented Dec 12, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
frontend ✅ Ready (Inspect) Visit Preview Dec 12, 2023 2:18pm

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 12, 2023 •
edited
Loading

📦 Next.js Bundle Analysis for @serlo/frontend

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@elbotho elbotho changed the title tmp: experiment e2e as standalone package refactor(e2e): add e2e-test as standalone package Dec 12, 2023
hejtful
hejtful approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@hejtful hejtful left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some fixes and improvements, looks good to me for now.

@elbotho elbotho marked this pull request as ready for review December 12, 2023 14:31
Entkenntnis
Entkenntnis approved these changes Dec 12, 2023
View reviewed changes
Copy link
Member

@Entkenntnis Entkenntnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! looks like we can retire the repo frontend-e2e-tests from now on

@elbotho elbotho merged commit fd7ed47 into staging Dec 12, 2023
13 checks passed
@elbotho elbotho deleted the feat-e2e-tests branch December 12, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Entkenntnis Entkenntnis Entkenntnis approved these changes

@hejtful hejtful hejtful approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elbotho @hejtful @Entkenntnis