Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(workspaces): rework eslint, fix tsconfig #3209

Merged
merged 7 commits into from
Dec 14, 2023

Conversation

elbotho
Copy link
Member

@elbotho elbotho commented Dec 13, 2023

It's still a bit weird but works better now :)

  • VSCode works as expected now
  • You can now run yarn lint inside of the editor package as well
  • global prettier and eslint scripts now run in editor and frontend workspace in parallel
  • tsc is only checked for the frontend now, the editor code that is used is checked by the frontend yarn lint:tsc as well

Remining errors inside of editor

  • tsc: some errors because svg import only works with the fileLoader and svgr correctly set up within the webpack config of nextjs. This will have to be solved when we build an editor package.

## Remaining errors inside of frontend:
Some problems because the types for mathfield can not be found for some reason
Build fails: https://github.com/serlo/frontend/actions/runs/7207871500/job/19635603628?pr=3209

Copy link

vercel bot commented Dec 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
frontend ✅ Ready (Inspect) Visit Preview Dec 14, 2023 0:34am

Copy link
Contributor

github-actions bot commented Dec 14, 2023

📦 Next.js Bundle Analysis for @serlo/frontend

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 103.46 KB (-7 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Sixty-four Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/ 85.37 KB (-3 B) 188.83 KB
/404 38.1 KB (-3 B) 141.55 KB
/500 38.1 KB (-3 B) 141.55 KB
/[...slug] 73.32 KB (🟢 -17 B) 176.77 KB
/___ab_dashboard/[id] 39.06 KB (-3 B) 142.51 KB
/___bot_or_not 90.66 KB (🟢 -17 B) 194.12 KB
/___cf_not_found 36.76 KB (-3 B) 140.22 KB
/___design 142.12 KB (-3 B) 245.57 KB
/___editor_preview 475.73 KB (🟢 -52 B) 579.18 KB
/___old_comments 101.58 KB (-3 B) 205.03 KB
/auth/error 55.63 KB (-3 B) 159.09 KB
/auth/login 80.59 KB (-3 B) 184.04 KB
/auth/logout 73.85 KB (-3 B) 177.31 KB
/auth/oauth/consent 54.2 KB (-3 B) 157.66 KB
/auth/oauth/login 80.59 KB (-3 B) 184.05 KB
/auth/oauth/logout 73.86 KB (-3 B) 177.32 KB
/auth/recovery 62.48 KB (-3 B) 165.93 KB
/auth/registration 63.42 KB (-3 B) 166.87 KB
/auth/settings 63.53 KB (-3 B) 166.99 KB
/auth/verification 62.83 KB (-3 B) 166.29 KB
/authorization/roles 64.91 KB (-3 B) 168.37 KB
/backend 38.83 KB (-3 B) 142.29 KB
/biologie 151.52 KB (🟢 -17 B) 254.97 KB
/chemie 151.52 KB (🟢 -17 B) 254.97 KB
/consent 37.27 KB (-3 B) 140.72 KB
/content-only/[...slug] 67.59 KB (🟢 -17 B) 171.05 KB
/discussions 96.27 KB (-3 B) 199.72 KB
/editor 99.49 KB (🟢 -17 B) 202.94 KB
/entity/create/[type]/[taxonomyId] 477.14 KB (🟢 -52 B) 580.6 KB
/entity/license/update/[id] 56.15 KB (-3 B) 159.61 KB
/entity/link/order/[id]/link 92.72 KB (-3 B) 196.18 KB
/entity/repository/add-revision/[...id] 476.35 KB (🟢 -52 B) 579.81 KB
/entity/repository/compare/[entity_id]/[revision_id] 100.65 KB (🟢 -20 B) 204.1 KB
/entity/repository/history/[id] 68.78 KB (-3 B) 172.24 KB
/entity/taxonomy/update/[id] 68.72 KB (-3 B) 172.18 KB
/entity/unrevised 44.13 KB (-3 B) 147.59 KB
/event/history 129.41 KB (-3 B) 232.87 KB
/event/history/[...slug] 133.14 KB (-3 B) 236.6 KB
/gleichungs-app 163.98 KB (-3 B) 267.44 KB
/informatik 151.52 KB (🟢 -17 B) 254.97 KB
/jobs/[[...jobId]] 51.21 KB (-3 B) 154.67 KB
/legal 36.8 KB (-3 B) 140.26 KB
/lerntipps 151.52 KB (🟢 -17 B) 254.97 KB
/license/detail/[id] 53.23 KB (🟢 -17 B) 156.68 KB
/mathe 151.51 KB (🟢 -17 B) 254.97 KB
/metadata 46.59 KB (-3 B) 150.05 KB
/nachhaltigkeit 151.52 KB (🟢 -17 B) 254.98 KB
/page/create 476.36 KB (🟢 -52 B) 579.82 KB
/pages 57.5 KB (-3 B) 160.95 KB
/privacy 40.14 KB (-3 B) 143.6 KB
/search 41.24 KB (-3 B) 144.69 KB
/spenden 52.11 KB (-3 B) 155.56 KB
/subscriptions/manage 111.24 KB (-3 B) 214.69 KB
/taxonomy/term/[copyOrMove]/batch/[id] 70.55 KB (-3 B) 174 KB
/taxonomy/term/create/[parent_id]/[id] 476.06 KB (🟢 -52 B) 579.51 KB
/taxonomy/term/sort/entities/[id] 95.26 KB (-3 B) 198.71 KB
/taxonomy/term/update/[id] 475.97 KB (🟢 -52 B) 579.42 KB
/terms 36.82 KB (-3 B) 140.28 KB
/user/[...userslug] 172.06 KB (-17 B) 275.51 KB
/user/me 36.6 KB (-3 B) 140.06 KB
/user/notifications 132.15 KB (-3 B) 235.6 KB
/user/settings 474.71 KB (🟢 -52 B) 578.16 KB
/uuid/recycle-bin 84.21 KB (-3 B) 187.66 KB
/wallet 41.86 KB (-3 B) 145.32 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@elbotho elbotho marked this pull request as ready for review December 14, 2023 14:04
@elbotho elbotho merged commit 6ae5d83 into editor-package Dec 14, 2023
11 checks passed
@elbotho elbotho deleted the editor-package-reworked-eslint branch December 14, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant