Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plugin-course): improve and force course editing #3543

Merged
merged 6 commits into from
Apr 11, 2024

Conversation

elbotho
Copy link
Member

@elbotho elbotho commented Mar 22, 2024

  • CoursePages are now opened in Editor inside the whole Course
  • Courses only show one CoursePage at a time in the editor

Downside: Authors will not be warned when there are previous unrevised revisions of course pages.

This is in preparation of moving CoursePages to the Courses editor state.

Copy link

vercel bot commented Mar 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
frontend ✅ Ready (Inspect) Visit Preview Apr 10, 2024 9:37pm

Copy link
Contributor

github-actions bot commented Mar 22, 2024

📦 Next.js Bundle Analysis for @serlo/frontend

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 104.34 KB (-2 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Nine Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/[...slug] 82.96 KB (🟡 +13 B) 187.31 KB
/___editor_preview 490.47 KB (🟡 +96 B) 594.82 KB
/content-only/[...slug] 74.33 KB (🟡 +13 B) 178.67 KB
/entity/create/[type]/[taxonomyId] 492.08 KB (🟡 +96 B) 596.42 KB
/entity/repository/add-revision/[...id] 491.29 KB (🟡 +96 B) 595.63 KB
/page/create 491.3 KB (🟡 +96 B) 595.64 KB
/taxonomy/term/create/[parent_id]/[id] 491 KB (🟡 +96 B) 595.34 KB
/taxonomy/term/update/[id] 490.91 KB (🟡 +96 B) 595.25 KB
/user/settings 489.7 KB (🟡 +96 B) 594.04 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@elbotho elbotho changed the title feat(plugin-course): improve and force corse editing feat(plugin-course): improve and force course editing Mar 22, 2024
Copy link
Contributor

@CodingDive CodingDive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great!

One small thing, that is not too critical and we can address in a follow-up PR
image

On my small laptop screen, the heading is scrolled to the right when loading the page http://localhost:3000/entity/repository/add-revision/155795#155798

@elbotho elbotho merged commit f5a8bc7 into staging Apr 11, 2024
9 checks passed
@elbotho elbotho deleted the edit-course-pages-in-course branch April 11, 2024 11:42
@elbotho elbotho mentioned this pull request Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants