Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment #4352

Merged
merged 74 commits into from
Dec 23, 2024
Merged

Deployment #4352

merged 74 commits into from
Dec 23, 2024

Conversation

elbotho
Copy link
Member

@elbotho elbotho commented Dec 13, 2024


Changes:

apps

packages

e2e-tests

Others

Copy link

vercel bot commented Dec 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
frontend ✅ Ready (Inspect) Visit Preview Dec 23, 2024 10:37am

Copy link
Contributor

github-actions bot commented Dec 13, 2024

📦 Next.js Bundle Analysis for @serlo/frontend

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 104.88 KB (🟡 +9 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Thirty-five Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/[...slug] 94.73 KB (🟡 +8.05 KB) 199.61 KB
/___bot_or_not 106.19 KB (🟡 +8.02 KB) 211.07 KB
/___editor_preview 663.61 KB (🟡 +26.43 KB) 768.48 KB
/auth/login 89.86 KB (-2 B) 194.74 KB
/auth/oauth/login 89.86 KB (-2 B) 194.74 KB
/auth/recovery 74.62 KB (-2 B) 179.5 KB
/auth/registration 75.43 KB (-2 B) 180.3 KB
/auth/settings 75.51 KB (-2 B) 180.38 KB
/auth/verification 74.78 KB (-2 B) 179.66 KB
/biologie 163.41 KB (🟡 +8.11 KB) 268.29 KB
/chemie 163.41 KB (🟡 +8.11 KB) 268.29 KB
/content-only/[...slug] 86.83 KB (🟡 +8.05 KB) 191.71 KB
/discussions 96.05 KB (🟡 +1 B) 200.92 KB
/editor 87.64 KB (🟡 +8.15 KB) 192.52 KB
/entity/create/[type]/[taxonomyId] 683.89 KB (🟡 +26.44 KB) 788.77 KB
/entity/repository/add-revision/[...id] 683.62 KB (🟡 +26.44 KB) 788.5 KB
/entity/repository/compare/[entity_id]/[revision_id] 99.39 KB (🟡 +8.05 KB) 204.27 KB
/event/history 123.32 KB (🟡 +93 B) 228.2 KB
/event/history/[...slug] 124.3 KB (🟡 +93 B) 229.17 KB
/event/history/user/profile/[username] 126.69 KB (🟡 +93 B) 231.56 KB
/informatik 163.41 KB (🟡 +8.11 KB) 268.29 KB
/jobs/[[...jobId]] 51.71 KB (🟡 +30 B) 156.59 KB
/lerntipps 163.41 KB (🟡 +8.11 KB) 268.29 KB
/license/detail/[id] 74.69 KB (🟡 +8.02 KB) 179.57 KB
/mathe 163.41 KB (🟡 +8.11 KB) 268.29 KB
/nachhaltigkeit 163.42 KB (🟡 +8.11 KB) 268.3 KB
/page/create 683.61 KB (🟡 +26.44 KB) 788.49 KB
/privacy 44.17 KB (-2 B) 149.05 KB
/subscriptions/manage 106.4 KB (🟡 +87 B) 211.27 KB
/taxonomy/term/[copyOrMove]/batch/[id] 84.22 KB (🟡 +138 B) 189.1 KB
/taxonomy/term/create/[parent_id]/[id] 683.36 KB (🟡 +26.44 KB) 788.23 KB
/taxonomy/term/update/[id] 683.3 KB (🟡 +26.44 KB) 788.18 KB
/user/notifications 125.65 KB (🟡 +93 B) 230.53 KB
/user/profile/[username] 182.47 KB (🟡 +8.13 KB) 287.35 KB
/user/settings 685.27 KB (🟡 +26.44 KB) 790.15 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

dependabot bot and others added 2 commits December 14, 2024 10:09
Bumps [nanoid](https://github.com/ai/nanoid) from 3.3.7 to 3.3.8.
- [Release notes](https://github.com/ai/nanoid/releases)
- [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md)
- [Commits](ai/nanoid@3.3.7...3.3.8)

---
updated-dependencies:
- dependency-name: nanoid
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
…n-image-upload

refactor(image-plugin): Show better error messages when the image upload fails
chore(deps): bump nanoid from 3.3.7 to 3.3.8
refactor(editor): package plugin icons as react components (to remove `dangerouslySetInnerHtml`)
…ning-message

feat(editor): add email to test environment warning message
fix(editor): skip other checks if we found editor state in paste
…serlo.org and on the content directly instead of the overlay
@CodingDive
Copy link
Contributor

Oops, I broke the plugin modal on serlo.org 🙈

image

Sorry about that!
Broke it here #4360, see https://de.serlo-staging.dev/___editor_preview

Stil works in prod https://de.serlo.org/___editor_preview.

Fixed by #4373

Mikey Stengel and others added 2 commits December 23, 2024 02:11
fix(editor): Modal on serlo.org by applying high z-index only in integrations on content instead of overlay
@elbotho elbotho marked this pull request as ready for review December 23, 2024 10:14
@elbotho elbotho merged commit d2267ab into production Dec 23, 2024
16 of 17 checks passed
elbotho added a commit that referenced this pull request Dec 23, 2024
Merge pull request #4352 from serlo/staging
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants