feat(editor-ui): onboarding welcome modal and hook #4363
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
📦 Next.js Bundle Analysis for @serlo/frontendThis analysis was generated by the Next.js Bundle Analysis action. 🤖
|
| Page | Size (compressed) |
|---|---|
global |
104.91 KB (🟡 +43 B) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
Eight Pages Changed Size
The following pages changed size from the code in this PR compared to its base branch:
| Page | Size (compressed) | First Load |
|---|---|---|
/___editor_preview |
643.42 KB (🟡 +6.2 KB) |
748.33 KB |
/editor |
79.49 KB (🟡 +1 B) |
184.4 KB |
/entity/create/[type]/[taxonomyId] |
663.71 KB (🟡 +6.2 KB) |
768.61 KB |
/entity/repository/add-revision/[...id] |
663.44 KB (🟡 +6.2 KB) |
768.34 KB |
/page/create |
663.42 KB (🟡 +6.2 KB) |
768.33 KB |
/taxonomy/term/create/[parent_id]/[id] |
663.17 KB (🟡 +6.2 KB) |
768.08 KB |
/taxonomy/term/update/[id] |
663.12 KB (🟡 +6.2 KB) |
768.03 KB |
/user/settings |
665.09 KB (🟡 +6.2 KB) |
770 KB |
Details
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.
| const localStorageValue = localStorage.getItem(localStorageKey) | ||
| if (localStorageValue === null) return setIsOpen(true) | ||
| const hasSeenModal = decodeWelcomeModalData(localStorageValue) |
There was a problem hiding this comment.
If you don't reuse the preferences:
Could we simplify this by just checking if the key exists?
That way we wouldn't need any type checks and parsing.
There was a problem hiding this comment.
We could, but I like the idea of decoding any value coming from localStorage, think it's a good practice.
Also, if we later want to expand on this in any way, for example using logged-in user ID to check if a specific user has seen the modal, in case of shared school devices, we can easily expand the codec.
Don't get me wrong, if you implemented it by just checking if the key exists, I wouldn't mind it. But since we already have this code, I wouldn't remove it.
packages/editor/src/editor-ui/welcome-modal/use-welcome-modal.ts
Outdated
Show resolved
Hide resolved
Linear issue: EDTR-200
Demo