Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use editor package in frontend #4380

Merged
merged 102 commits into from
Jan 28, 2025

Conversation

hejtful
Copy link
Contributor

@hejtful hejtful commented Dec 30, 2024

Linear issue: EDTR-104

After merge:

  • Update strings
  • Save partners logos as Image plugin on Partners page in production
  • Fix e2e tests on staging
  • Ask testing group for a testing round on staging

E2E:

  • 100-learners fail because of CORS when ran from local - should pass in staging
  • 300-authors fail because of missing German strings - should pass when strings added
  • 490-save-changes fail because of missing German strings - should pass when strings added

Copy link

vercel bot commented Dec 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
frontend ✅ Ready (Inspect) Visit Preview Jan 28, 2025 0:54am

+ rename its file to match context name + move it to editor contexts directory + remove deprecated isSerlo property + update useIsSerlo helper to check for editor variant instead
Copy link
Contributor

github-actions bot commented Jan 17, 2025

📦 Next.js Bundle Analysis for @serlo/frontend

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 105.36 KB (🟡 +330 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Seventy-one Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/ 83.13 KB (🟢 -2.41 KB) 188.49 KB
/404 40.03 KB (🟢 -2.19 KB) 145.4 KB
/500 40.03 KB (🟢 -2.19 KB) 145.39 KB
/[...slug] 105.56 KB (🟡 +10.54 KB) 210.92 KB
/___batch_license_tool 53.83 KB (🟢 -2.33 KB) 159.19 KB
/___bot_or_not 113.72 KB (🟡 +7.35 KB) 219.08 KB
/___cf_not_found 38.25 KB (🟢 -2.19 KB) 143.61 KB
/___design 143.55 KB (🟢 -2.19 KB) 248.91 KB
/___editor_preview 84.03 KB (🟢 -582.29 KB) 189.39 KB
/___experiments 1.3 KB (🟡 +5 B) 106.66 KB
/___old_comments 97.4 KB (🟢 -2.11 KB) 202.76 KB
/auth/___activate_vidis 38.54 KB (🟢 -2.19 KB) 143.9 KB
/auth/error 63.07 KB (🟢 -2.19 KB) 168.43 KB
/auth/login 87.67 KB (🟢 -2.19 KB) 193.03 KB
/auth/logout 78.38 KB (🟢 -2.19 KB) 183.74 KB
/auth/oauth/consent 52.98 KB (🟢 -2.19 KB) 158.35 KB
/auth/oauth/login 87.67 KB (🟢 -2.19 KB) 193.04 KB
/auth/oauth/logout 78.38 KB (🟢 -2.19 KB) 183.75 KB
/auth/recovery 72.44 KB (🟢 -2.19 KB) 177.8 KB
/auth/registration 73.23 KB (🟢 -2.19 KB) 178.6 KB
/auth/settings 73.32 KB (🟢 -2.19 KB) 178.68 KB
/auth/verification 72.59 KB (🟢 -2.19 KB) 177.96 KB
/authorization/roles 64.6 KB (🟢 -2.28 KB) 169.97 KB
/backend 40.31 KB (🟢 -2.19 KB) 145.68 KB
/biologie 172.08 KB (🟡 +8.42 KB) 277.44 KB
/chemie 172.07 KB (🟡 +8.43 KB) 277.44 KB
/consent 38.83 KB (🟢 -2.19 KB) 144.19 KB
/content-only/[...slug] 94.54 KB (🟡 +7.42 KB) 199.91 KB
/discussions 93.94 KB (🟢 -2.11 KB) 199.3 KB
/editor 58.1 KB (🟢 -29.81 KB) 163.46 KB
/entity/create/[type]/[taxonomyId] 222.86 KB (🟢 -463.75 KB) 328.22 KB
/entity/license/update/[id] 54.92 KB (🟢 -2.29 KB) 160.29 KB
/entity/repository/add-revision/[...id] 222.53 KB (🟢 -463.82 KB) 327.89 KB
/entity/repository/compare/[entity_id]/[revision_id] 110.51 KB (🟡 +10.94 KB) 215.87 KB
/entity/repository/history/[id] 67.78 KB (🟢 -2.19 KB) 173.14 KB
/entity/taxonomy/update/[id] 67.68 KB (🟢 -1.84 KB) 173.04 KB
/entity/unrevised 45.09 KB (🟢 -2.19 KB) 150.45 KB
/event/history 122.45 KB (🟢 -958 B) 227.81 KB
/event/history/[...slug] 123.43 KB (🟢 -952 B) 228.79 KB
/event/history/user/profile/[username] 125.81 KB (🟢 -958 B) 231.18 KB
/gleichungs-app 162.19 KB (🟢 -2.1 KB) 267.56 KB
/informatik 172.08 KB (🟡 +8.43 KB) 277.44 KB
/jobs/[[...jobId]] 49.53 KB (🟢 -2.19 KB) 154.89 KB
/legal 38.31 KB (🟢 -2.19 KB) 143.67 KB
/lerntipps 172.08 KB (🟡 +8.42 KB) 277.44 KB
/license/detail/[id] 81.69 KB (🟡 +6.83 KB) 187.06 KB
/mathe 172.07 KB (🟡 +8.43 KB) 277.44 KB
/mathe-aufgaben 39.05 KB (🟢 -2.19 KB) 144.42 KB
/mathe-pruefungen/[region] 75.54 KB (🟢 -2.18 KB) 180.9 KB
/metadata 47.92 KB (🟢 -2.19 KB) 153.28 KB
/nachhaltigkeit 172.08 KB (🟡 +8.43 KB) 277.45 KB
/page/create 222.53 KB (🟢 -463.8 KB) 327.89 KB
/pages 56.24 KB (🟢 -2.29 KB) 161.6 KB
/privacy 38.79 KB (🟢 -5.38 KB) 144.16 KB
/search 40.31 KB (🟢 -2.19 KB) 145.68 KB
/spenden 52.14 KB (🟢 -2.71 KB) 157.5 KB
/subscriptions/manage 105.4 KB (🟢 -1.05 KB) 210.77 KB
/taxonomy/term/[copyOrMove]/batch/[id] 70.12 KB (🟢 -13.99 KB) 175.48 KB
/taxonomy/term/create/[parent_id]/[id] 222.23 KB (🟢 -463.85 KB) 327.59 KB
/taxonomy/term/sort/entities/[id] 89.88 KB (🟢 -2.09 KB) 195.25 KB
/taxonomy/term/update/[id] 222.15 KB (🟢 -463.87 KB) 327.52 KB
/team 46.05 KB (🟢 -2.19 KB) 151.41 KB
/terms 38.33 KB (🟢 -2.19 KB) 143.69 KB
/user/[...userslug] 38.14 KB (🟢 -2.19 KB) 143.5 KB
/user/me 38.12 KB (🟢 -2.19 KB) 143.49 KB
/user/notifications 124.68 KB (🟢 -1.03 KB) 230.05 KB
/user/profile/[username] 190.58 KB (🟡 +7.86 KB) 295.94 KB
/user/settings 224.32 KB (🟢 -463.68 KB) 329.68 KB
/uuid/recycle-bin 78.38 KB (🟢 -2.28 KB) 183.74 KB
/wallet 44.42 KB (🟡 +1.2 KB) 149.78 KB
/willkommen 84.5 KB (🟢 -2.19 KB) 189.86 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@hejtful hejtful changed the title refactor: use editor package in frontend (WIP) refactor: use editor package in frontend Jan 28, 2025
@hejtful hejtful marked this pull request as ready for review January 28, 2025 12:43
@hejtful hejtful merged commit b5b896a into staging Jan 28, 2025
8 checks passed
@hejtful hejtful deleted the refactor/use-editor-package-in-frontend branch January 28, 2025 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants