Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(exercise): add nicer fallback feedback (random) #4434

Merged
merged 4 commits into from
Jan 29, 2025

Conversation

elbotho
Copy link
Member

@elbotho elbotho commented Jan 28, 2025

quick cute feature (and some minor refactoring) in between all the serious stuff 🐸
https://linear.app/serlo/issue/EDTR-254/make-default-exercise-feedback-more-motivating

@elbotho elbotho requested a review from hejtful January 28, 2025 14:10
Copy link

vercel bot commented Jan 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
frontend ✅ Ready (Inspect) Visit Preview Jan 28, 2025 2:12pm

Copy link
Contributor

📦 Next.js Bundle Analysis for @serlo/frontend

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 105.04 KB (-1 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Seventy Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/ 85.72 KB (🟡 +191 B) 190.76 KB
/404 42.41 KB (🟡 +191 B) 147.45 KB
/500 42.41 KB (🟡 +191 B) 147.45 KB
/[...slug] 95.21 KB (🟡 +191 B) 200.25 KB
/___batch_license_tool 56.34 KB (🟡 +191 B) 161.38 KB
/___bot_or_not 106.55 KB (🟡 +191 B) 211.6 KB
/___cf_not_found 40.63 KB (🟡 +191 B) 145.67 KB
/___design 145.93 KB (🟡 +191 B) 250.97 KB
/___editor_preview 666.54 KB (🟡 +224 B) 771.58 KB
/___old_comments 99.7 KB (🟡 +191 B) 204.74 KB
/auth/___activate_vidis 40.92 KB (🟡 +191 B) 145.96 KB
/auth/error 65.45 KB (🟡 +191 B) 170.49 KB
/auth/login 90.05 KB (🟡 +191 B) 195.09 KB
/auth/logout 80.76 KB (🟡 +191 B) 185.8 KB
/auth/oauth/consent 55.36 KB (🟡 +191 B) 160.4 KB
/auth/oauth/login 90.05 KB (🟡 +191 B) 195.09 KB
/auth/oauth/logout 80.76 KB (🟡 +191 B) 185.8 KB
/auth/recovery 74.81 KB (🟡 +191 B) 179.85 KB
/auth/registration 75.61 KB (🟡 +191 B) 180.65 KB
/auth/settings 75.69 KB (🟡 +191 B) 180.74 KB
/auth/verification 74.97 KB (🟡 +191 B) 180.01 KB
/authorization/roles 67.07 KB (🟡 +191 B) 172.11 KB
/backend 42.69 KB (🟡 +191 B) 147.73 KB
/biologie 163.84 KB (🟡 +191 B) 268.88 KB
/chemie 163.83 KB (🟡 +191 B) 268.88 KB
/consent 41.2 KB (🟡 +191 B) 146.24 KB
/content-only/[...slug] 87.31 KB (🟡 +191 B) 192.35 KB
/discussions 96.24 KB (🟡 +191 B) 201.28 KB
/editor 88.09 KB (🟡 +191 B) 193.13 KB
/entity/create/[type]/[taxonomyId] 686.83 KB (🟡 +224 B) 791.87 KB
/entity/license/update/[id] 57.4 KB (🟡 +191 B) 162.44 KB
/entity/repository/add-revision/[...id] 686.56 KB (🟡 +224 B) 791.6 KB
/entity/repository/compare/[entity_id]/[revision_id] 99.76 KB (🟡 +191 B) 204.8 KB
/entity/repository/history/[id] 70.16 KB (🟡 +191 B) 175.2 KB
/entity/taxonomy/update/[id] 69.71 KB (🟡 +191 B) 174.75 KB
/entity/unrevised 47.46 KB (🟡 +191 B) 152.5 KB
/event/history 123.57 KB (🟡 +191 B) 228.61 KB
/event/history/[...slug] 124.54 KB (🟡 +191 B) 229.59 KB
/event/history/user/profile/[username] 126.94 KB (🟡 +191 B) 231.98 KB
/gleichungs-app 164.48 KB (🟡 +191 B) 269.52 KB
/informatik 163.84 KB (🟡 +191 B) 268.88 KB
/jobs/[[...jobId]] 51.9 KB (🟡 +191 B) 156.94 KB
/legal 40.69 KB (🟡 +191 B) 145.73 KB
/lerntipps 163.84 KB (🟡 +191 B) 268.88 KB
/license/detail/[id] 75.05 KB (🟡 +191 B) 180.09 KB
/mathe 163.83 KB (🟡 +191 B) 268.87 KB
/mathe-aufgaben 41.43 KB (🟡 +191 B) 146.47 KB
/mathe-pruefungen/[region] 77.91 KB (🟡 +191 B) 182.95 KB
/metadata 50.29 KB (🟡 +191 B) 155.33 KB
/nachhaltigkeit 163.84 KB (🟡 +191 B) 268.88 KB
/page/create 686.55 KB (🟡 +224 B) 791.59 KB
/pages 58.71 KB (🟡 +191 B) 163.75 KB
/privacy 44.36 KB (🟡 +191 B) 149.4 KB
/search 42.69 KB (🟡 +191 B) 147.73 KB
/spenden 55.03 KB (🟡 +191 B) 160.07 KB
/subscriptions/manage 106.64 KB (🟡 +191 B) 211.68 KB
/taxonomy/term/[copyOrMove]/batch/[id] 84.29 KB (🟡 +191 B) 189.33 KB
/taxonomy/term/create/[parent_id]/[id] 686.29 KB (🟡 +224 B) 791.34 KB
/taxonomy/term/sort/entities/[id] 92.16 KB (🟡 +191 B) 197.2 KB
/taxonomy/term/update/[id] 686.24 KB (🟡 +224 B) 791.28 KB
/team 48.43 KB (🟡 +191 B) 153.47 KB
/terms 40.71 KB (🟡 +191 B) 145.75 KB
/user/[...userslug] 40.51 KB (🟡 +191 B) 145.55 KB
/user/me 40.5 KB (🟡 +191 B) 145.54 KB
/user/notifications 125.9 KB (🟡 +191 B) 230.94 KB
/user/profile/[username] 182.9 KB (🟡 +191 B) 287.94 KB
/user/settings 688.21 KB (🟡 +224 B) 793.25 KB
/uuid/recycle-bin 80.85 KB (🟡 +191 B) 185.89 KB
/wallet 43.41 KB (🟡 +191 B) 148.45 KB
/willkommen 86.87 KB (🟡 +191 B) 191.92 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link
Contributor

@hejtful hejtful left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small step for the codebase, giant leap for the learner experience 🌔

@elbotho elbotho merged commit 8061f50 into staging Jan 29, 2025
9 checks passed
@elbotho elbotho deleted the feat/randomized-fallback-exercise-feedback branch January 29, 2025 12:59
@github-actions github-actions bot mentioned this pull request Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants