chore(editor-upload): use new asset infra in serlo.org production #4442
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
📦 Next.js Bundle Analysis for @serlo/frontendThis analysis was generated by the Next.js Bundle Analysis action. 🤖 Seven Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. |
elbotho
changed the title
| return shouldUseNewUpload() ? uploader : oldUploader | ||
| const uploader = (file: File) => | ||
| uploadFile({ file, editorVariant, userId, isSerlo }) | ||
| return shouldUseNewUpload(isSerlo) ? uploader : oldUploader | ||
| } | ||
|
|
||
| // while testing |
There was a problem hiding this comment.
Is this obsolete now?
Also the console.log('using new upload method and temporary bucket') line?
There was a problem hiding this comment.
I wish :)
I think it's not because there are integrations outside of serlo.org that are not staging/dev and I want to activate this for serlo.org production only right now.
There was a problem hiding this comment.
I only meant the // while testing comment and the console log. Might be confusing, if we're using it on production now.
Same for integrations, the console log is not super informative without context.
There was a problem hiding this comment.
Ahh I see.
On Serlo the console.log won't trigger (early return).
But I moved the comment down so it's a bit more clear.
I'd keep the console.log for now for us to check which method is active when working with integrations.
| process.env.NODE_ENV === 'development' | ||
| ? 'editor.serlo.dev' | ||
| : 'editor.serlo.dev' // TODO: Change to production bucket after testing | ||
| const isSerloProduction = process.env.NEXT_PUBLIC_ENV === 'production' |
There was a problem hiding this comment.
Just to mention that I added a helper hook to #4348 , in the packages/editor/src/core/hooks/use-is-serlo.ts file, when merging staging to that branch:
export function useIsNextjsProduction(): boolean {
return process.env.NEXT_PUBLIC_ENV === 'production'
}
So this will be duplicated once both PRs are merged.
No description provided.