[Chore] Factor out code from wizard_structure
#712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pasqu4le
approved these changes
Sep 15, 2023
krendelhoff2
force-pushed
the
krendelhoff/chore-refactor-baking
branch
from
3e3b4a7 to
f9251cd
Compare
Problem: `wizard_structure` module contains too many definitions, which became hard to maintain. Solution: Factor out utils into separate module.
Problem: wizard_structure contains too many definitions, which became hard to maintain. Solution: Put all validators under `validators` module. Strip `_validator` from its functions, since they are supposed to be called with module qualified. Add typing information to the `Validator` class.
Problem: wizard_structure contains too many definitions, which became hard to maintain. Solution: Put all common steps-related code under `steps` module.
krendelhoff2
force-pushed
the
krendelhoff/chore-refactor-baking
branch
from
f9251cd to
d7eda94
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is preparatory PR for the #568.
Related issue(s)
Resolves #
Related changes (conditional)
I checked whether I should update the README
I checked whether native packaging works, i.e. native binary packages
can be successfully built.
Stylistic guide (mandatory)