Skip to content

Multiple fixes for the graph/state machine generation functionality #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 27, 2025
Merged

Multiple fixes for the graph/state machine generation functionality #33

merged 4 commits into from
Jun 27, 2025

Conversation

oEscal
Copy link
Contributor

@oEscal oEscal commented Jun 27, 2025

This PR adds multiple bug fixes for the feature implemented in #30:

  • The parallel state did not have any initial state in the state machine.
  • When creating the parallel state in the state machine, the code was creating double the transitions for its actions.
  • When the parallel state had branches with subflows, it was creating an empty state apart from the state with all subflow.
  • In actions, with one or more subflows and one or more functions, the code was not creating the transitions between the subflows' states and the functions' states.
  • Renamed the source_code method (legacy from the TypeScript JDK) to generate.

oEscal added 4 commits June 24, 2025 17:50
@oEscal
small fix
3bfeed3 
Signed-off-by: Pedro Escaleira <[email protected]>
@oEscal
fixed parallel state details: was calling generate_composite_state, w…
a53be24 
…hen the generate_actions_info already calls it (double calling)

Signed-off-by: Pedro Escaleira <[email protected]>
@oEscal
state machine to nested state fixed: now it is more robust to cases w…
197a540 
…here the machine state is a branch in parallel states

Signed-off-by: Pedro Escaleira <[email protected]>
@oEscal
fixed bug where the subflow would not be connected to any other actio…
8aae4a4 
…n in the set of its actions; also renamed the source_code function to generate

Signed-off-by: Pedro Escaleira <[email protected]>
cdavernas
cdavernas approved these changes Jun 27, 2025
View reviewed changes
Copy link
Member

@cdavernas cdavernas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Cheers ❤️

@cdavernas cdavernas merged commit ee0a9ca into serverlessworkflow:main Jun 27, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdavernas cdavernas cdavernas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oEscal @cdavernas