Update names of lib targets #163
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en nesting. r=dholbert,dshin As per spec. This fixes an interop-2024 subtest, so would be nice to get in sooner rather than later. Most of the changes are rejiggering from passing the allowed flags to pass the forbidden_flags, which was a bit easier now that we need to check for them for specificity. Differential Revision: https://phabricator.services.mozilla.com/D232735
…rigin color. r=layout-reviewers,dshin,emilio When the result of a resolved relative color is in the color(srgb ..) syntax, make sure not to clamp the components during the calculations. Differential Revision: https://phabricator.services.mozilla.com/D232338
…lic (r=emilio) Differential Revision: https://phabricator.services.mozilla.com/D233126
This allows for 4 tag bits in tagged pointer representations that point to this value. Signed-off-by: Nico Burns <[email protected]> Differential Revision: https://phabricator.services.mozilla.com/D233128
…SED TREE Backed out changeset 1635a42fc205 (bug 1939791) Backed out changeset f48d5b6b6d8b (bug 1939791)
…ut-reviewers,emilio Division denominators used to be assumed as resolvable numbers, but now with color components we can have "numbers" that are only resolved later, so we should handle that. Differential Revision: https://phabricator.services.mozilla.com/D233236
…tages in ServoStyleConstsInlines.h. CLOSED TREE
…orrectly. r=layout-reviewers,emilio - Serialize color components with `calc(..)` when specified in a calc node. - Channel keywords outside `calc(..)` are serialized without `calc(..)`. Differential Revision: https://phabricator.services.mozilla.com/D233234
…lic (r=emilio) Differential Revision: https://phabricator.services.mozilla.com/D233126
…om properties should not mark any non-custom property as invalid-at-computed time. r=firefox-style-system-reviewers,emilio Differential Revision: https://phabricator.services.mozilla.com/D232858
…-reviewers,emilio Differential Revision: https://phabricator.services.mozilla.com/D233218
…ion_keywords when layout.css.anchor-positioning.enabled is true. r=dshin. Differential Revision: https://phabricator.services.mozilla.com/D233257
…in :has introduced through nesting. r=firefox-style-system-reviewers,emilio Differential Revision: https://phabricator.services.mozilla.com/D233532
…=firefox-style-system-reviewers,emilio While required for Bug 1912241, unopaque operation can easily break the `Sync` trait assumption for `OpaqueElement`. So, tighten the usage of unopaqued element to ensure that it is used only for read-only access, and that it does not leak out for general use. Also, add documentation around functions for unopaque operation, cautioning against its usage, if possible. Differential Revision: https://phabricator.services.mozilla.com/D233758
…macro comment. r=dshin Trivial doc cleanup that I noticed when going to edit this file. Differential Revision: https://phabricator.services.mozilla.com/D234091
This enables us to parse the pseudo, but it's not yet connected to anything. Differential Revision: https://phabricator.services.mozilla.com/D234092
…inside-top-layer.tentative.html. CLOSED TREE Backed out changeset 2b07b9e7bf57 (bug 1936113) Backed out changeset a88e93dff614 (bug 1936113) Backed out changeset 9cfc0a675a42 (bug 1936113) Backed out changeset 716bdadbea2a (bug 1936113) Backed out changeset 4ee0855e448f (bug 1936113)
…macro comment. r=dshin Trivial doc cleanup that I noticed when going to edit this file. Differential Revision: https://phabricator.services.mozilla.com/D234091
This enables us to parse the pseudo, but it's not yet connected to anything. Differential Revision: https://phabricator.services.mozilla.com/D234092
…+ and Rust. r=firefox-style-system-reviewers,emilio Differential Revision: https://phabricator.services.mozilla.com/D231255
…from Rust side. r=firefox-style-system-reviewers,emilio Differential Revision: https://phabricator.services.mozilla.com/D231256
…nctions from Rust side. r=firefox-style-system-reviewers,emilio `has_anchor_function` in `CalcLengthPercentage` will be used to avoid traversing the calc tree if we know the calc node tree does not have any anchor function. Anchor resolution is done in a separate phase, because layout code queries for `auto` insets without having a full context for the percentage basis. Differential Revision: https://phabricator.services.mozilla.com/D231257
…sStyleStruct.cpp. CLOSED TREE Backed out changeset d55070e64ced (bug 1923763) Backed out changeset a92a0bc6047f (bug 1923763) Backed out changeset 2203e2c5268e (bug 1923763) Backed out changeset 0cc5e744c01a (bug 1923763) Backed out changeset d2139afa933b (bug 1923763) Backed out changeset 93e59980eac1 (bug 1923763) Backed out changeset 8018734b5491 (bug 1923763)
This was only needed because computed images serialized differently, but we fixed that in bug 1738693. Differential Revision: https://phabricator.services.mozilla.com/D234968
…+ and Rust. r=firefox-style-system-reviewers,emilio Differential Revision: https://phabricator.services.mozilla.com/D231255
…from Rust side. r=firefox-style-system-reviewers,emilio Differential Revision: https://phabricator.services.mozilla.com/D231256
…nctions from Rust side. r=firefox-style-system-reviewers,emilio `has_anchor_function` in `CalcLengthPercentage` will be used to avoid traversing the calc tree if we know the calc node tree does not have any anchor function. Anchor resolution is done in a separate phase, because layout code queries for `auto` insets without having a full context for the percentage basis. Differential Revision: https://phabricator.services.mozilla.com/D231257
…firefox-style-system-reviewers,emilio Differential Revision: https://phabricator.services.mozilla.com/D249628
…wers,emilio Differential Revision: https://phabricator.services.mozilla.com/D249629
…ld bustages & wpt failures. This reverts commit f94a0ccf5af51ed3ac6038b78890dd57adfda748. Revert "Bug 1923961: Adjust WPT expectations. r=firefox-style-system-reviewers,emilio" This reverts commit e3e24626a399771ab4f38846ebaa90ac4243566b. Revert "Bug 1923961: Resolve anchor() in calc(). r=firefox-style-system-reviewers,emilio" This reverts commit a21f60c569d0a734e8c5a3b57e658d9e5754de83. Revert "Bug 1923961: Initial implementation of anchor lookup for anchor(). r=firefox-style-system-reviewers,emilio" This reverts commit daaa53a9ce52c6cc617c84ed109d1f2e295f7f4b. Revert "Bug 1923961: Make `nsLayoutUtils::GetRectRelativeToFrame` take in const ptrs. r=firefox-style-system-reviewers,emilio" This reverts commit c1db75e7fc78d8f1367d31292f108f5961913507. Revert "Bug 1923961: Pass the new AnchorPosResolutionParams to servo side. r=firefox-style-system-reviewers,emilio" This reverts commit e0f8f99c693d4d3d28d13bc5981d70e66d079777. Revert "Bug 1923961: Unify anchor resolution parameters and use it for inset resolution. r=layout-reviewers,emilio" This reverts commit adc70f84935dfe6ee5490d06e7863453a52757f4. Revert "Bug 1923961: Expose `AnchorSide` to C++. r=firefox-style-system-reviewers,boris" This reverts commit b917ffcec6cce6643e05efbf07f51cfccec3ec6e.
…wers,boris Differential Revision: https://phabricator.services.mozilla.com/D249624
…firefox-style-system-reviewers,emilio Differential Revision: https://phabricator.services.mozilla.com/D249628
…wers,emilio Differential Revision: https://phabricator.services.mozilla.com/D249629
…ld bustages @ GeckoBindings.cpp This reverts commit ec57e25d897914b6663f3657c4d1a9b13b46e9e2. Revert "Bug 1923961: Adjust WPT expectations. r=firefox-style-system-reviewers,emilio" This reverts commit f2612695a72ce4d7210cb488d92b930b9d6ec723. Revert "Bug 1923961: Resolve anchor() in calc(). r=firefox-style-system-reviewers,emilio" This reverts commit b206c5264ba77881691bcee2dfe7ef8a6f43e44b. Revert "Bug 1923961: Initial implementation of anchor lookup for anchor(). r=firefox-style-system-reviewers,emilio" This reverts commit 56c17701c5ef3716569b3d35440cdc9f1bce58fb. Revert "Bug 1923961: Make `nsLayoutUtils::GetRectRelativeToFrame` take in const ptrs. r=firefox-style-system-reviewers,emilio" This reverts commit 34fb773837dcd0a051f10000f3823dcf23a1180d. Revert "Bug 1923961: Pass the new AnchorPosResolutionParams to servo side. r=firefox-style-system-reviewers,emilio" This reverts commit 73477e329675d5c9d5f1840cc1f4133d50c756d0. Revert "Bug 1923961: Unify anchor resolution parameters and use it for inset resolution. r=layout-reviewers,emilio" This reverts commit 8461579472e42a5ac259ed7c439d2f445cba048c. Revert "Bug 1923961: Expose `AnchorSide` to C++. r=firefox-style-system-reviewers,boris" This reverts commit 7ecbb38056fc88aafc275a52d38a7e568d4a8c80.
…wers,boris Differential Revision: https://phabricator.services.mozilla.com/D249624
…firefox-style-system-reviewers,emilio Differential Revision: https://phabricator.services.mozilla.com/D249628
…wers,emilio Differential Revision: https://phabricator.services.mozilla.com/D249629
…reviewers,dao This patch got a bit larger than expected mostly to deal well with windows HCM, but the TLDR is that we introduce Button*border colors, and deal with them in the non-native theme, rather than hard-coding them. We also leave the previous hardcoded colors in the standin set, so that web content doesn't change behavior, and reorder a bit the colors to be closer together. Differential Revision: https://phabricator.services.mozilla.com/D251648
…in-reviewers This starts using the latest stable release of derive_more. The previous version was in beta and is not maintained anymore. An important reason to upgrade is so that this latest derive_more version will eventually become available on the Rust Playground. Related: servo#117 Related: rust-lang/rust-playground#1133 Related: JelteF/derive_more#445 Differential Revision: https://phabricator.services.mozilla.com/D236782
…t. r=emilio Fixes the failing nested-declarations-cssom-whitespace WPT by adding the empty string rule check as per https://drafts.csswg.org/cssom/#serialize-a-css-rule. Differential Revision: https://phabricator.services.mozilla.com/D252019
…med view transition pseudo-elements. r=view-transitions-reviewers,firefox-style-system-reviewers,emilio Extend the syntax of `<pt-name-selector>` to `<pt-name-and-class-selector>` for named view transition pseudo elements. Also, add a new parameter in the parser to make the difference between the pseudo-element string and the pseudo-element selector. The matching part is not implemented yet and we will do that in Bug 1964949. Differential Revision: https://phabricator.services.mozilla.com/D251967
Any ancestors of this commit are from upstream mozilla-central, with some filtering and renaming. Our patches and sync tooling start here. The sync tooling has all been squashed into this commit, based on: https://github.com/servo/stylo/commits/64731e10dc8ef87ef52aa2fb9f988c3b2530f3a7
This is a rebase of 7fdb9ef Signed-off-by: Oriol Brufau <[email protected]>
There is shared code assuming that the `transition-behavior` value is an Option, so it's simpler to add the servo pref back until Gecko decides to remove its pref too. Signed-off-by: Oriol Brufau <[email protected]>
Signed-off-by: Oriol Brufau <[email protected]>
Signed-off-by: Oriol Brufau <[email protected]>
Signed-off-by: Oriol Brufau <[email protected]>
Signed-off-by: Oriol Brufau <[email protected]>
Mozilla have deprecated https://github.com/mozilla/gecko-dev in favour of https://github.com/mozilla-firefox/firefox. This PR switches our syncing code over to the new repo. A one-off manual deletion of local _cache and _filtered directories will be required to use this PR.
The `main` branch is used by the upstream Firefox repository, so use that everywhere. Signed-off-by: Martin Robinson <[email protected]>
Signed-off-by: Nico Burns <[email protected]>
|
Sorry, I think Github closed this because we are now using the new upstream repo, and the history was too different. Can you rebase and open a new PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the package names of the crates have all been updated to stylo*, it seems like that name of the crate within the package is still style* in some cases. This causes the docs.rs url to be https://docs.rs/stylo/latest/style rather than https://docs.rs/stylo/latest/stylo.
This PR changes this to be consistent by simply deleting the
name = "..."lines which causes the crate name to default to the package name.It also removes the
crate_nameattribute from thestylo_traitscrate. These need to match the crate name inCargo.toml. And as upstream have not yet renamed this crate keeping this line would mean extra diff. This line comes from the very first version ofstyle_traitsin 2015 (d7ba5ee) and none of the other crates have this attribute so I strongly suspect it is not necessary.