Add blinded contact records to Contacts and ConvoInfoVolatile #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jagerman
reviewed
Jun 16, 2025
jagerman
reviewed
Jun 16, 2025
jagerman
reviewed
Jun 16, 2025
jagerman
reviewed
Jun 16, 2025
jagerman
reviewed
Jun 16, 2025
mpretty-cyro
force-pushed
the
feature/blinded-contacts
branch
from
470d8ad to
47c5164
Compare
jagerman
force-pushed
the
feature/blinded-contacts
branch
from
0e68cb0 to
e883776
Compare
|
Rebased on top of #54 with an update applied to use the same type-safe timestamp. |
jagerman
approved these changes
Jul 28, 2025
jagerman
approved these changes
Jul 28, 2025
This uses std::chrono::sys_seconds for the new profile_updated timestamp field, so that we can avoid the unfortunate bug that happened in earlier releases where some clients violated the documented restrictions and passed milliseconds or microseconds: sys_seconds is absolutely unambiguous as to what it holds and makes such an error virtually impossible. - Adds `session::to_sys_seconds(int)` that can get a proper sys_seconds from a maybe-s, ms, or µs value by guessing based on the magnitude. - Add methods for getting/setting sys_seconds timestamps from/into configs.
There are a lot of internal calls such as `maybe_int(c,
"key").value_or(0)` and `maybe_string(c, "key").value_or("")`. This
makes it them slightly less cumbersome by adding `int_or_0` and
`string_or_empty` functions that handle the fallback-to-0/empty
automatically.
jagerman
force-pushed
the
feature/blinded-contacts
branch
from
e883776 to
0bcc986
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds blinded contact records to
ContactsandConvoInfoVolatileto simplify syncing them between devices and allowlibSessionto construct the full conversation listNote: This is based on #51