App Disguise tests #44
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Miki-Session
commented
May 14, 2025
Miki-Session
commented
- Adds tests for app disguise feature
- Visual check - do the icons match
- Set an alternate app icon (currently Android only, test tags are pending for iOS)
Bilb
reviewed
May 15, 2025
| await sleepFor(2000); | ||
| // Open app library and check for disguised app | ||
| await runScriptAndLog( | ||
| `${getAdbFullPath()} -s ${device.udid} shell input swipe 500 1700 500 500` |
There was a problem hiding this comment.
no other way than doing that?
There was a problem hiding this comment.
Sure there is I'll take another look
Comment on lines
+45
to
+48
| // The disguised app must be uninstalled otherwise every following test will fail | ||
| await runScriptAndLog( | ||
| `${getAdbFullPath()} -s ${device.udid} uninstall network.loki.messenger`, | ||
| true |
There was a problem hiding this comment.
you should close the app, even if that's not technically required
Comment on lines
+111
to
+120
| case 'android': | ||
| return { | ||
| strategy: 'accessibility id', | ||
| selector: 'Appearance', | ||
| } as const; | ||
| case 'ios': | ||
| return { | ||
| strategy: 'accessibility id', | ||
| selector: 'Appearance', | ||
| } as const; |
There was a problem hiding this comment.
those are the same, not a needed change, but because I am not sure you knew, you can do
case 'android':
case 'ios':
return {
strategy: 'accessibility id',
selector: 'Appearance',
} as const;```
There was a problem hiding this comment.
Ah yeah this is a very obvious one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.