Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/template resolution by external service #180

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Merge branch 'develop' into feature/template-resolution-by-external-s…
…ervice

# Conflicts:
#	core/core-services-impl/src/test/java/com/sflpro/notifier/services/template/impl/TemplatingConfigurationImplTest.java
VS201085 committed May 20, 2022
commit be025255dbb5d5b669fd4258349a194412c68013
2 changes: 2 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
@@ -110,3 +110,5 @@ kafka.sasl.mechanism=PLAIN
kafka.sasl.jaas.config=org.apache.kafka.common.security.plain.PlainLoginModule required username="<API_KEY>" password="<API_SECRET>";
kafka.security.protocol=SASL_SSL
```

For detailed configuration of templating and i18n please see [Template resolution documentation](/docs/template-resolution.md)
20 changes: 13 additions & 7 deletions docs/template-resolution.md
Original file line number Diff line number Diff line change
@@ -6,9 +6,13 @@ General intro

Description of this approach

Configuration
Configuration example
```yaml
path: sfdsfsdf
notifier:
templates:
externalUrl: false
path: file:/templates
extension: .ftl
```

### File naming
@@ -25,16 +29,18 @@ Description of this approach

Configuration example
```yaml
configuration:
example:
url: true
notifier:
templates:
externalUrl: true
path: https://example.com
extension: .ftl
```

### External Service API Specification

Implement the following API endpoints:
Implement the following API endpoints, assuming .ftl template extension:

GET /templates/<template_name>
GET /<template_name>.ftl
Returns the template content.

Endpoints should return the following responses: