-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/conf file #9
base: main
Are you sure you want to change the base?
Conversation
@SamTV12345 Why naming fields & vars |
That's the big question. Do we strive to replace pnpm then we probably need to obey the things pnpm does. Other than that we could also roll our own thing and hope it will work and get adoption. It's the same with the other variables. Will we get adoption if someone needs to rework his entire setup. It's like a marketing decision 🙂 |
That's a good question 🤔 At least we'll need to have craft working by itself initially. Then, we can have adapters for lock files to parse it for each package manager(npm, yarn v1.*, pnpm) later. (example: https://github.com/yarnpkg/berry/blob/master/packages/plugin-pnpm/sources/PnpmLinker.ts#L14) This was a busy month. In case of any updates, I'll respond faster then |
Alright :) Yes let's just get craft to work on its own. I saw that pnpm also offers migrations for the lockfiles of other languages. Can we merge this or are there things left to do with this pr? |
@SamTV12345 Yes, let's merge this, just please fix the conflict |
I'll solve the merge conflicts tomorrow so we can move on with the next topic. |
Perfect, ty! |
This adds support for config files. You can now adapt your local conf file with craft :)