Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/conf file #9

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

SamTV12345
Copy link
Contributor

@SamTV12345 SamTV12345 commented Nov 15, 2024

This adds support for config files. You can now adapt your local conf file with craft :)

  • Just run craft config get to retrieve a key, --json is also supported
  • craft config set key value to set a key value combination
  • craft list to list all configured things

@shahen94
Copy link
Owner

@SamTV12345 Why naming fields & vars pnpm ?

@SamTV12345
Copy link
Contributor Author

@SamTV12345 Why naming fields & vars pnpm ?

That's the big question. Do we strive to replace pnpm then we probably need to obey the things pnpm does. Other than that we could also roll our own thing and hope it will work and get adoption. It's the same with the other variables. Will we get adoption if someone needs to rework his entire setup. It's like a marketing decision 🙂

@shahen94
Copy link
Owner

shahen94 commented Dec 27, 2024

That's a good question 🤔

At least we'll need to have craft working by itself initially. Then, we can have adapters for lock files to parse it for each package manager(npm, yarn v1.*, pnpm) later. (example: https://github.com/yarnpkg/berry/blob/master/packages/plugin-pnpm/sources/PnpmLinker.ts#L14)

This was a busy month. In case of any updates, I'll respond faster then

@SamTV12345
Copy link
Contributor Author

That's a good question 🤔

At least we'll need to have craft working by itself initially. Then, we can have adapters for lock files to parse it for each package manager(npm, yarn v1.*, pnpm) later. (example: https://github.com/yarnpkg/berry/blob/master/packages/plugin-pnpm/sources/PnpmLinker.ts#L14)

This was a busy month. In case of any updates, I'll respond faster then

Alright :) Yes let's just get craft to work on its own. I saw that pnpm also offers migrations for the lockfiles of other languages. Can we merge this or are there things left to do with this pr?

@shahen94
Copy link
Owner

@SamTV12345 Yes, let's merge this, just please fix the conflict

@SamTV12345
Copy link
Contributor Author

I'll solve the merge conflicts tomorrow so we can move on with the next topic.

@shahen94
Copy link
Owner

Perfect, ty!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants