Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: patch setServerCertificate() on older Tizens & webOS #6696

Merged
merged 2 commits into from
May 29, 2024

Conversation

tykus160
Copy link
Member

@tykus160 tykus160 commented May 29, 2024

We've tried to enable setting server certificates to optimize playback start, but turned out that with our widevine certificate shaka was throwing 6004 error. The issue is not reproducible starting from Tizen 5.5. The same certificate was working properly also on Chrome.

@avelad avelad added type: bug Something isn't working correctly priority: P1 Big impact or workaround impractical; resolve before feature release platform: Tizen Issues affecting Tizen labels May 29, 2024
@avelad avelad requested a review from joeyparrish May 29, 2024 07:17
@avelad avelad added the component: EME The issue involves the Encrypted Media Extensions web API label May 29, 2024
@avelad avelad added this to the v4.9 milestone May 29, 2024
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 100.00%

@tykus160 tykus160 changed the title fix: patch setServerCertificate() on older Tizens fix: patch setServerCertificate() on older Tizens & webOS May 29, 2024
@avelad avelad added the platform: WebOS Issues affecting WebOS label May 29, 2024
@avelad avelad merged commit 9e26166 into shaka-project:main May 29, 2024
17 checks passed
avelad pushed a commit that referenced this pull request May 29, 2024
We've tried to enable setting server certificates to optimize playback
start, but turned out that with our widevine certificate shaka was
throwing 6004 error. The issue is not reproducible starting from Tizen
5.5. The same certificate was working properly also on Chrome.
@tykus160 tykus160 deleted the wt-tizen-disable-cert branch May 29, 2024 14:24
joeyparrish pushed a commit that referenced this pull request May 31, 2024
We've tried to enable setting server certificates to optimize playback
start, but turned out that with our widevine certificate shaka was
throwing 6004 error. The issue is not reproducible starting from Tizen
5.5. The same certificate was working properly also on Chrome.
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Jul 28, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Jul 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: EME The issue involves the Encrypted Media Extensions web API platform: Tizen Issues affecting Tizen platform: WebOS Issues affecting WebOS priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants