Update jest.config.js #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Comment on lines
1
to
6
| module.exports = { | ||
| preset: 'ts-jest', | ||
| testEnvironment: 'node', | ||
| testTimeout: 5000000, // the more node involve in testing, the higher the timeout requires | ||
| verbose: true, | ||
| roots: ['<rootDir>/test/unit'], | ||
| setupFiles: ['<rootDir>/test/unit/setup.ts'], |
There was a problem hiding this comment.
Suggestion: Consider re-adding the testTimeout configuration to prevent tests from running indefinitely, especially if they involve asynchronous operations or external services. [possible issue, importance: 8]
New proposed code:
module.exports = {
preset: 'ts-jest',
testEnvironment: 'node',
+ testTimeout: 5000, // Adjusted timeout for better test performance
verbose: true,
roots: ['<rootDir>/test/unit'],
setupFiles: ['<rootDir>/test/unit/setup.ts'],
testMatch: ['**/__tests__/**/*.+(ts|tsx|js)', '**/?(*.)+(spec|test).+(ts|tsx|js)'],
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
configuration changes
Description
Reduced the test timeout in
jest.config.js.Removed an excessive timeout setting for tests.
Changes walkthrough 📝
jest.config.js
Reduce test timeout setting in Jest configurationjest.config.js