Skip to content

Commit

Permalink
VS2022 - Very basic support for VS2022
Browse files Browse the repository at this point in the history
Opening either solution in VS2022 should no longer prompt to upgrade VC++ version/Win10 SDK.

Having both VS2019 and VS2022 installed might be a problem if VS2022 doesn't have the required components installed.

Update .vsconfig Win10 SDK version to 19041 (same as Chromium requires for build)
  • Loading branch information
amaitland committed Dec 8, 2021
1 parent a79e839 commit a6a66be
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 8 deletions.
2 changes: 1 addition & 1 deletion .vsconfig
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
"Microsoft.VisualStudio.Component.VC.Redist.14.Latest",
"Microsoft.VisualStudio.ComponentGroup.NativeDesktop.Core",
"Microsoft.VisualStudio.Component.VC.CLI.Support",
"Microsoft.VisualStudio.Component.Windows10SDK.18362",
"Microsoft.VisualStudio.Component.Windows10SDK.19041",
"Microsoft.VisualStudio.Workload.NativeDesktop",
"Microsoft.NetCore.Component.DevelopmentTools",
"Microsoft.NetCore.Component.Runtime.3.1",
Expand Down
13 changes: 6 additions & 7 deletions CefSharp.props
Original file line number Diff line number Diff line change
Expand Up @@ -3,16 +3,15 @@

<PropertyGroup>
<VisualStudioProductVersion>2019</VisualStudioProductVersion>
<!-- <VisualStudioProductVersion Condition="'$(VisualStudioVersion)'=='15.0'">2017</VisualStudioProductVersion> -->
<!-- <VisualStudioProductVersion Condition="'$(VisualStudioVersion)'=='16.0'">2017</VisualStudioProductVersion> -->
<!-- <VisualStudioProductVersion Condition="'$(VisualStudioVersion)'=='16.0' AND Exists('$(SolutionDir)packages\$(CefSdkVer)\CEF\$(Platform)\$(Configuration)\VS2019\libcef_dll_wrapper.lib')">2019</VisualStudioProductVersion> -->
<VisualStudioProductVersion Condition="'$(VisualStudioVersion)'=='17.0' AND Exists('$(SolutionDir)packages\$(CefSdkVer)\CEF\$(Platform)\$(Configuration)\VS2022\libcef_dll_wrapper.lib')">VS2022</VisualStudioProductVersion>

<PlatformToolset>v142</PlatformToolset>
<!--<PlatformToolset Condition="'$(VisualStudioVersion)'=='14.0'">v140</PlatformToolset>
<PlatformToolset Condition="'$(VisualStudioVersion)'=='15.0'">v141</PlatformToolset>
<PlatformToolset Condition="'$(VisualStudioVersion)'=='16.0'">v142</PlatformToolset>-->
<PlatformToolset Condition="'$(VisualStudioVersion)'=='17.0'">v143</PlatformToolset>

<WindowsTargetPlatformVersion Condition="'$(VisualStudioVersion)'=='16.0'">10.0</WindowsTargetPlatformVersion>
<!-- TODO: We might need to do something here when VS2019 and VS2022 are installed -->
<WindowsTargetPlatformVersion>10.0</WindowsTargetPlatformVersion>
<!-- <WindowsTargetPlatformVersion Condition="'$(VisualStudioVersion)'=='16.0'">10.0</WindowsTargetPlatformVersion> -->
<!-- <WindowsTargetPlatformVersion Condition="'$(VisualStudioVersion)'=='17.0'">10.0</WindowsTargetPlatformVersion> -->

<CefSharpBrowserSubprocessPostBuildEvent>
<![CDATA[
Expand Down

0 comments on commit a6a66be

Please sign in to comment.