Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(faq): using shorebird for all dart changes #176

Merged
merged 4 commits into from
Jan 19, 2024
Merged

docs(faq): using shorebird for all dart changes #176

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2ca49f2
docs(faq): using shorebird for all dart changes
felangel Jan 19, 2024
e0076fd
Update docs/faq.md
felangel Jan 19, 2024
d2fc239
Update docs/faq.md
felangel Jan 19, 2024
3d486ae
suggestions
felangel Jan 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions docs/faq.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,16 @@ Also Shorebird does not support changing native code (e.g. Java/Kotlin on
Android or Objective-C/Swift on iOS). The tool will warn you during an
attempted patch if you have changed native code.

### Can I use Shorebird for all my Dart changes?

Technically speaking, yes, a Shorebird patch can update any Dart code.
Note that depending on how you distribute your apps, some store agreements
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Note that depending on how you distribute your apps, some store agreements
However, some store agreements

Copy link
Contributor Author

@felangel felangel Jan 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think leaving it as is is more explicit personally since it clearly indicates shorebird is not involved in store distribution 🤷

expect feature changes to go through store review.
Notably Apple's App Store requires that an update "does not change the
primary purpose of the Application by providing features or functionality
that are inconsistent with the intended and advertised purpose of the Application."
Also note that patch sizes correlate with the total amount of Dart changed from the original released app (each patch is a diff against the released dart code, not a diff to the previous patch).

### Does Shorebird submit to the stores for me?

Shorebird does not currently support submitting to the app stores on your
Expand Down