Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixing up music.md for best practices on changing midi channel synths #379

Merged
merged 5 commits into from
Sep 12, 2024
Merged

fixing up music.md for best practices on changing midi channel synths #379

merged 5 commits into from
Sep 12, 2024

Conversation

bwhitman
Copy link
Collaborator

No description provided.

@bwhitman bwhitman requested a review from dpwe September 12, 2024 13:01
@bwhitman
Copy link
Collaborator Author

OK, this should be that. I tested voices changing patches without music_map, using add_synth instead, seems to work.

dpwe
dpwe approved these changes Sep 12, 2024
View reviewed changes
Copy link
Collaborator

@dpwe dpwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

docs/music.md Show resolved Hide resolved
docs/tulip_api.md Outdated Show resolved Hide resolved
@bwhitman
Copy link
Collaborator Author

thank you !!!!!

@bwhitman bwhitman merged commit c7bce79 into main Sep 12, 2024
1 check passed
@bwhitman bwhitman deleted the musicmd2 branch September 12, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpwe dpwe dpwe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bwhitman @dpwe