Staging #5
Open
Staging #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ode_to_Xcode_9 Feature/ag 1426 upgrade the i os code to xcode 9
merge Xcode 9 code
Actually it fixes the error that app can not open a URL if it contains space.
… the iOS system can identifies. If the URL of PDF file contains space, it is needed to convert space to %20.
… the iOS system can identifies. If the URL of PDF file contains space, it is needed to convert space to %20.
…PDF file can not be opened if its URL contains % owing to using stringByAddingPercentEncodingWithAllowedCharacters method.
…RL which the iOS system can identifies." This reverts commit 8db2c2c.
…ary to encode the URL.
…ng_CMS_integrated_calendars' * feature/AG-2069_IOS_doesn't_open_Calendar_PDF_links_using_CMS_integrated_calendars: check URL is encoded or not. If it has not been encoded, it is necessary to encode the URL. recover master branch because the modification causes another issue: PDF file can not be opened if its URL contains % owing to using stringByAddingPercentEncodingWithAllowedCharacters method. If the URL of PDF file contains %, it is supported to right URL which the iOS system can identifies. If the URL of PDF file contains space, it is needed to convert space to %20. # Conflicts: # src/ios/ChildBrowserViewController.m
# Conflicts: # src/ios/ChildBrowserViewController.m
…ng_CMS_integrated_calendars' into dev * feature/AG-2069_IOS_doesn't_open_Calendar_PDF_links_using_CMS_integrated_calendars: check URL is encoded or not. If it has not been encoded, it is necessary to encode the URL.
…r branch. the code exists in Dev and staging branch.
…n_PDF_files_from_CMS_News_and_Events_when_the_PDF_file_is_located_in_a_Sub-folder_with_spaces make useless change in order to add the code of AG-2069 back to maste…
merge into Staging from Dev
…into_new_iOS_project Feature/ag 2790 setup code into new ios project
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.