Guard against d3 'length' undefined error #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Occurs when Rickshaw.Graph.render() is called with no data. Here we simply check that scenario before calling d3. See issue#438.
|
Any chance this pull request will be accepted? |
@djensen47 Yes; however, it would be more likely to be accepted with tests. |
|
Hi @abirmingham, Would you be interested in adding tests so we can get this merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Occurs when Rickshaw.Graph.render() is called with no data. Here we
simply check that scenario before calling d3. See issue #438.
This is my naive solution to the issue, however it does fix the issue in my application.