-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modified setup.py and pyamgx/System.pyx. #37
base: main
Are you sure you want to change the base?
Conversation
Changes needed to successfully install pyamgx on latest amgx install, Python3, and Ubuntu 22.04
@@ -38,7 +38,8 @@ | |||
pyamgx.initialize() | |||
|
|||
from pyamgx_solver import PyAMGXSolver | |||
with open (os.environ['AMGX_DIR']+'/core/configs/AMG_CLASSICAL_PMIS.json') as f: | |||
#with open (os.environ['AMGX_DIR']+'/core/configs/AMG_CLASSICAL_PMIS.json') as f: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's just delete this?
@@ -73,12 +77,19 @@ | |||
library_dirs = [ | |||
numpy.get_include(), | |||
] + AMGX_lib_dirs, | |||
<<<<<<< HEAD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a bad merge here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for replying. Yes, I think I did a gitdiff and it messed up my files. Let me look these files over and get back to you. I'll rename the "tests" directory as you suggested.
Rod
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for putting this together! For the examples, can we avoid the prefix test
? I believe that will confuse pytest
and it will attempt to run the module as if it contained unit tests.
Changes needed to successfully install pyamgx
on latest amgx install, Python3, and Ubuntu 22.04. Also corrected AMGX path for examples/FiPy/diffusion.py (changed core to src).