feat: fix Mellanox Build & add missing Kernel Flags #1048
Conversation
Which precisely? Also, your commit doesn't contain a second body line (well, just add description there) and is missing a signed-off-by line, which indicates accepting Developer Certificate of Origin. Please add it using git commit --amend -s |
| @@ -1,5 +1,5 @@ | |||
| name: mellanox-ofed-pkg | |||
| variant: scratch | |||
| variant: alpine | |||
There was a problem hiding this comment.
Not sure whether or not we should do so. Why doesn't it work without variant: alpine, what's missing in our tools, and why not add it there?
| rm /bin/mktemp | ||
| ln -s /toolchain/bin/mktemp /bin/ |
There was a problem hiding this comment.
Could you please add a comment why is this replacement done?
| mellanox_ofed_version: 5.9-0.5.6.0 | ||
| mellanox_ofed_sha256: 4503258cbe92b00c734e612c3a7ad1d71e023fdffae2a2c119f7b537505e499c | ||
| mellanox_ofed_sha512: 58604ea89aa8351727532c48f0c59b4e533ba8bfcef9533f45d94e15ffdcf3a5c464398706cad14ebf3826b132972bd044fadbf7f047e60bdb0c2a454c96acd7 | ||
| mellanox_ofed_version: 24.07-0.6.1.0 |
There was a problem hiding this comment.
Please also include a note about the version update in the commit message
| @@ -84,6 +84,7 @@ TARGETS += xfsprogs | |||
| TARGETS += kernel | |||
| TARGETS += drbd-pkg | |||
| TARGETS += gasket-driver-pkg | |||
| TARGETS += mellanox-ofed-pkg | |||
There was a problem hiding this comment.
this file is generated, instead .kres.yaml should be updated with make rekres after that
When trying to build with full NVME support, the build fails with the following error:
|
…s/pkgs into reactivate-mellanox-ofed
does this means it's better than the in-tree kernel mlx5 drivers, just trying to gauge if we need to build and maintain this? 🤔 |
|
also wants to know if this co-exist with in-tree kernel drivers, might need to denylist udev loading mlx5 by default I guess |
This PR is for fixing the Mellanox OFED Driver Package and adding the missing Kernel Flags for it to build.
The NVME Part of the Dirver is disabled because it has Source Code related problems.
Signed-off-by: Feniarus [email protected]