Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an explicit example of kubelet config for the
local-path-provisioner
paragraph.Pull Request
What? (description)
I think the local storage page lacks a clear example of how to integrate
local-path-provisioner
Why? (reasoning)
While playing with
local-path-provisioner
on my lab cluster, I had sometimes some dataloss I couldn't explain. After long troubleshooting, I identified some strange behaviour when usingvolumeMount
with thesubPath
statement.I initially thought it could a bug in the provisioner itself, and I proposed an extra test there (rancher/local-path-provisioner#467).
After a while, and lots of tests, I ended up trying to replicate the kubelet config which is shown in the
hostPath
paragraph, and everything went back to the expected behaviour.Afterwards, it may be seen as obvious, but I really thought that
hostPath
andlocal-path-provisioner
were 2 distinct paragraphs, hence my mistake.Feel free to reject if you think it's a duplicate and/or unnecessary.
Acceptance
Please use the following checklist:
make conformance
)make fmt
)make lint
)make docs
)make unit-tests
)