Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update local-storage.md #9805

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Update local-storage.md #9805

merged 1 commit into from
Nov 27, 2024

Conversation

shtouff
Copy link
Contributor

@shtouff shtouff commented Nov 26, 2024

Add an explicit example of kubelet config for the local-path-provisioner paragraph.

Pull Request

What? (description)

I think the local storage page lacks a clear example of how to integrate local-path-provisioner

Why? (reasoning)

While playing with local-path-provisioner on my lab cluster, I had sometimes some dataloss I couldn't explain. After long troubleshooting, I identified some strange behaviour when using volumeMount with the subPath statement.

I initially thought it could a bug in the provisioner itself, and I proposed an extra test there (rancher/local-path-provisioner#467).

After a while, and lots of tests, I ended up trying to replicate the kubelet config which is shown in the hostPath paragraph, and everything went back to the expected behaviour.

Afterwards, it may be seen as obvious, but I really thought that hostPath and local-path-provisioner were 2 distinct paragraphs, hence my mistake.

Feel free to reject if you think it's a duplicate and/or unnecessary.

Acceptance

Please use the following checklist:

  • [ x] you linked an issue (if applicable)
  • you included tests (if applicable)
  • you ran conformance (make conformance)
  • you formatted your code (make fmt)
  • you linted your code (make lint)
  • [ x] you generated documentation (make docs)
  • you ran unit-tests (make unit-tests)

See make help for a description of the available targets.

Copy link
Member

@smira smira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you, that's a nice catch!

Add an explicit example of kubelet config.

Signed-off-by: Rémi Paulmier <[email protected]>
Signed-off-by: Andrey Smirnov <[email protected]>
@smira
Copy link
Member

smira commented Nov 27, 2024

/m

@talos-bot talos-bot merged commit 9adaf7f into siderolabs:main Nov 27, 2024
50 checks passed
@shtouff shtouff deleted the patch-1 branch November 27, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants