-
-
Notifications
You must be signed in to change notification settings - Fork 633
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
1b013d1
commit d5de9e7
Showing
7 changed files
with
63 additions
and
47 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,37 +1,41 @@ | ||
[node-mysql]: https://github.com/mysqljs/mysql | ||
[docs-contributing]: https://sidorares.github.io/node-mysql2/docs/contributing/website | ||
|
||
# Contributing Guidelines | ||
|
||
## Introduction | ||
|
||
Contributions are always welcomed. You can help `node-mysql2` community in various ways. Here are our major priorities, listed in order of importance. | ||
Contributions are always welcomed. You can help **MySQL2** community in various ways. Here are our major priorities, listed in order of importance: | ||
|
||
- `node-mysql` API incompatibility fixes | ||
- Documentation | ||
- Adding tests or improving existing ones | ||
- Improving benchmarks | ||
- Bug Fixes | ||
- TODO from source | ||
- Performance improvements | ||
- Add Features | ||
- [Node MySQL][node-mysql] API incompatibility fixes | ||
- [Documentation][docs-contributing] | ||
- Adding tests or improving existing ones | ||
- Improving benchmarks | ||
- Bug Fixes | ||
- TODO from source | ||
- Performance improvements | ||
- Add Features | ||
|
||
## Security Issues | ||
|
||
Please contact project maintainers privately before opening a security issue on Github. It will allow us to fix the issue before attackers know about it. | ||
|
||
**Contact** | ||
### Contact | ||
|
||
- Andrey Sidorov, [email protected] | ||
|
||
## New Features | ||
|
||
Its better to discuss an API before actually start implementing it. You can open an issue on Github. We can discuss design of API and implementation ideas. | ||
It's better to discuss an API before actually start implementing it. You can open an issue on Github. We can discuss design of API and implementation ideas. | ||
|
||
## Development | ||
|
||
We assume you already have these tools installed on your system | ||
- MySQL Server | ||
- Node.JS | ||
We assume you already have these tools installed on your system: | ||
|
||
- MySQL Server | ||
- Node.JS | ||
|
||
As `node-mysql2` is purely JS based you can develop it on Linux, Mac or Windows. Please follow these steps | ||
As **MySQL2** is purely JS based you can develop it on Linux, Mac or Windows. Please follow these steps | ||
|
||
```bash | ||
# clone node-mysql2 | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,15 @@ | ||
# Acknowledgements | ||
|
||
- Internal protocol is written by @sidorares [MySQL-Native](https://github.com/sidorares/nodejs-mysql-native) | ||
- Constants, SQL parameters interpolation, Pooling, `ConnectionConfig` class taken from [node-mysql](https://github.com/mysqljs/mysql) | ||
- SSL upgrade code based on @TooTallNate [code](https://gist.github.com/TooTallNate/848444) | ||
- Secure connection / compressed connection api flags compatible to [MariaSQL](https://github.com/mscdex/node-mariasql/) client. | ||
- [Contributors](https://github.com/sidorares/node-mysql2/graphs/contributors) | ||
[mysql-native]: https://github.com/sidorares/nodejs-mysql-native | ||
[sidorares]: https://github.com/sidorares | ||
[node-mysql]: https://github.com/mysqljs/mysql | ||
[TooTallNate]: https://gist.github.com/TooTallNate | ||
[starttls.js]: https://gist.github.com/TooTallNate/848444 | ||
[node-mariasql]: https://github.com/mscdex/node-mariasql | ||
[contributors]: https://github.com/sidorares/node-mysql2/graphs/contributors | ||
|
||
- Internal protocol is written by [@sidorares][sidorares] [MySQL-Native][mysql-native]. | ||
- Constants, SQL parameters interpolation, Pooling, `ConnectionConfig` class taken from [Node MySQL][node-mysql]. | ||
- SSL upgrade code based on [@TooTallNate][TooTallNate] [code][starttls.js]. | ||
- Secure connection / compressed connection api flags compatible to [MariaSQL][node-mariasql] client. | ||
- [Contributors][contributors]. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,11 @@ | ||
# API and Configuration | ||
|
||
[node-mysql]: https://github.com/mysqljs/mysql | ||
|
||
MySQL2 is mostly API compatible with [Node MySQL][node-mysql]. | ||
|
||
One known incompatibility is that `DECIMAL` values are returned as strings whereas in [Node MySQL][node-mysql] they are returned as numbers. This includes the result of `SUM()` and `AVG()` functions when applied to `INTEGER` arguments. This is done deliberately to avoid loss of precision - see https://github.com/sidorares/node-mysql2/issues/935. | ||
|
||
:::info | ||
If you find any other incompatibility with [Node MySQL][node-mysql], Please report via Issue tracker. We will fix reported incompatibility on priority basis. | ||
::: | ||
|
||
[node-mysql]: https://github.com/mysqljs/mysql |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters