input: protocoldata: make sure lookup_protocol_name stays safe from NULL pointer dereferencing #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ULL pointer dereferencing As of today, the code does not crash because all protocols have names. But the name of the first element is not checked to be non-NULL before calling strcmp(). This can result in a future crash if the code logic changes. This is mostly a change to robustify the lookup_protocol_name() function. Also, this commit simplifies the indexing logic of the protocols array.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of today, the code does not crash because all protocols have names. But the name of the first element is not checked to be non-NULL before calling strcmp(). This can result in a future crash if the code logic changes.
This is mostly a change to robustify the lookup_protocol_name() function.
Also, this commit simplifies the indexing logic of the protocols array.