Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embed status of public good instance #268

Merged
merged 2 commits into from
Dec 7, 2023

Conversation

haydentherapper
Copy link
Contributor

Small wording changes for deployment page too.

Summary

Release Note

Documentation

Small wording changes for deployment page too.

Signed-off-by: Hayden Blauzvern <[email protected]>
Copy link

netlify bot commented Nov 3, 2023

Deploy Preview for docssigstore ready!

Name Link
🔨 Latest commit 9b9ce36
🔍 Latest deploy log https://app.netlify.com/sites/docssigstore/deploys/65455ed20406f6000828b236
😎 Deploy Preview https://deploy-preview-268--docssigstore.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: Hayden Blauzvern <[email protected]>
@haydentherapper
Copy link
Contributor Author

Any suggestions on a better place to embed this status?

Copy link
Collaborator

@ltagliaferri ltagliaferri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the status can even go on the home page? I would maybe add one line of context regardless, something like "Status of public-good instance," or "Review / check status of public-good instance"

@ltagliaferri
Copy link
Collaborator

@haydentherapper — any thoughts about moving this to the first page or adding the context sentence?

@haydentherapper
Copy link
Contributor Author

Yes, sorry, haven't gotten a chance to! I'll likely do both.

@ltagliaferri
Copy link
Collaborator

No worries, just was not sure if you got the message or if I could help

@haydentherapper
Copy link
Contributor Author

Do you think it would look good in the header, or just in the overview page?

@ltagliaferri
Copy link
Collaborator

Sorry, @haydentherapper , I think the header is fine!

@ltagliaferri
Copy link
Collaborator

I'll merge and we can always change it!

@ltagliaferri ltagliaferri merged commit 67b9b74 into sigstore:main Dec 7, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants