Added navigation to hamburger menu #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recapitulated the sidebar in the hamburger menu for navigation Display is hidden on large and up screens Signed-off-by: Patrick Smyth <[email protected]>
✅ Deploy Preview for docssigstore ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ltagliaferri
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds an instance of the navigation sidebar to the hamburger menu on mobile devices. There is currently no navigation menu on small or medium screens.
Consideration and Testing
To see the change, view the site's hamburger menu (click the three lines in top right that appear on small or medium screen sizes). There should be a navigation menu at the bottom of the popout panel.
The code here adds a second instance of the sidebar to the page, which is not ideal. It is hidden on large and up screens using display:none, just as the current sidebar is hidden on displays of medium or below. I don't like that this adds a second instance of the sidebar for page load, etc., but I don't see a way to work the current sidebar into the hanburger menu without this approach.
Notes
Resolves #304