Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sigstore CLI flags --staging and --identity-token #320

Merged
merged 2 commits into from
Nov 12, 2024

Conversation

spencerschrock
Copy link
Contributor

Summary

This is a followup of #319 to allow passing an identity token via the CLI. The staging flag was also added to allow easier testing.

Release Note

NONE

Documentation

NONE

@spencerschrock spencerschrock requested review from a team as code owners November 12, 2024 17:28
This is a followup of a0fa173 to allow
passing an identity token via the CLI. The staging flag was also added
to allow easier testing.

Signed-off-by: Spencer Schrock <[email protected]>
Copy link
Collaborator

@mihaimaruseac mihaimaruseac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm thinking to avoid the envvars as much as possible, at least in the library parts. It makes for harder to debug behavior

Signed-off-by: Spencer Schrock <[email protected]>
@mihaimaruseac
Copy link
Collaborator

Thank you

@mihaimaruseac mihaimaruseac merged commit e70a1fd into sigstore:main Nov 12, 2024
21 checks passed
@spencerschrock spencerschrock deleted the token-cli branch November 12, 2024 18:51
@mihaimaruseac mihaimaruseac added this to the V1 release milestone Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants