use unique hash engine for each file hasher #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the factory could cause workers to share a hash engine, leading to hashes that were wrong or duplicated. This ultimately created invalid manifests, affecting signature creation and verification. Signed-off-by: Spencer Schrock <[email protected]>
spencerschrock
force-pushed
the
shared-hasher
branch
from
4293bce to
1cc4783
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously, the factory could cause workers to share a hash engine, leading to hashes that were wrong or duplicated. This ultimately created invalid manifests, affecting signature creation and verification.
Discovered and tested during #324, which I'll keep separate.
Release Note
NONE
Documentation