change default chunk size to 1 MB #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
spencerschrock
commented
Jan 16, 2025
| @@ -31,7 +31,7 @@ def create_file_of_given_size(path: str, size: int) -> None: | |||
| """ | |||
| file_path = pathlib.Path(path) | |||
| file_path.parent.mkdir(parents=True, exist_ok=True) | |||
| chunk_size = 8192 | |||
| chunk_size = 1048576 | |||
There was a problem hiding this comment.
This change wasn't benchmarked (but also isn't required to have good performance), but changed for unity.
spencerschrock
force-pushed
the
optimize-chunk
branch
from
5b7febd to
b77baf6
Compare
This value was based on the benchmarks in f0a6e96. The exact improvement is platform dependent, but we observed improvements of 50-80%. Signed-off-by: Spencer Schrock <[email protected]>
spencerschrock
force-pushed
the
optimize-chunk
branch
from
b77baf6 to
b490161
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
change default chunk size to 1 MB
This value was based on the benchmarks in f0a6e96.
Release Note
Documentation
NONE